Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset sync should show warning message to user, if sync is already established between two devices #2134

Closed
GeetaSarvadnya opened this issue Nov 14, 2018 · 4 comments · Fixed by brave/brave-core#917

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 14, 2018

Description

Reset sync should show warning message to user, if sync is already established between two devices

Steps to Reproduce

  1. Launch brave beta with --enable-brave-sync flag
  2. Sync two devices and make sure sync is established b/n 2 devices (Bookmarks are imported and
    synced between two devices)
  3. Click on Reset sync on Device1
  4. Observe that there is no warning message displayed

Actual result:

Click on Reset Sync is not showing any waring message

Expected result:

Click on Reset sync should show warning message to user, if sync is already established b/n devices

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on beta build

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@kjozwiak @LaurenWags @srirambv @btlechowski

@GeetaSarvadnya GeetaSarvadnya added this to the 0.57.x - Beta milestone Nov 14, 2018
@GeetaSarvadnya GeetaSarvadnya added priority/P4 Planned work. We expect to get to it "soon". browser-laptop-parity labels Nov 14, 2018
@cezaraugusto cezaraugusto self-assigned this Nov 15, 2018
@cezaraugusto
Copy link
Contributor

fixed by brave/brave-core#917

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 27, 2018

Verification Passed on

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows

Verified passed with

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X
  • Verified STR from description, Cancel button closes warning and does not reset Sync. OK button closes warning and does reset sync.
    screen shot 2018-11-27 at 3 29 39 pm

Verification Passed on

Brave 0.57.7 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux

pasted_image_at_2018-11-27__7_54_pm

@srirambv
Copy link
Contributor

Removed QA pass label. Need to verify it against beta again

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Dec 4, 2018

Verification Passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows

image

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-12 at 10 20 17 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment