Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync chain creation fails after system comes online #2137

Closed
srirambv opened this issue Nov 14, 2018 · 1 comment · Fixed by brave/brave-core#973
Closed

Sync chain creation fails after system comes online #2137

srirambv opened this issue Nov 14, 2018 · 1 comment · Fixed by brave/brave-core#973

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 14, 2018

Description

Sync chain creation fails after system comes online

Steps to Reproduce

  1. Launch brave with --enable-brave-sync
  2. Disconnect device from network
  3. Open Brave Sync and click on I am new to Sync
  4. Type in a device name and click Setup Sync, modal dismissed without any warning
  5. Close modal and try again with a different device name, doesn't show any warning message
  6. Connect device back to network and try creating sync chain again, doesn't work
  7. Restart browser and try again works fine and sync chain gets created

Actual result:

https://youtu.be/1OPqo5b7aKE

Expected result:

Browser shouldn't be capable of creating sync chain when device comes online and without having to restart the browser

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.57.6 Chromium: 71.0.3578.31 (Official Build) beta (64-bit)
Revision c88fdf2a4ce19a713615ca4fbde7a0d0b5fe2363-refs/branch-heads/3578@{#427}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa @darkdh @AlexeyBarabash

@btlechowski
Copy link

btlechowski commented Dec 11, 2018

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 10 x64

When device is offline, No Internet connection modal is shown.
Going online will create a sync chain on next attempt.

There are some special cases when the No Internet connection modal is not shown #2468

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified No internet connection message for attempting to 'Set up Sync' with both I am new to Sync and I have an existing Sync code paths.
    screen shot 2018-12-11 at 5 39 18 pm
    screen shot 2018-12-11 at 5 39 47 pm

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
  • Verified No internet connection message for attempting to 'Set up Sync' with both I am new to Sync and I have an existing Sync code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants