Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking IPFS button from dweb.link shared audio doesn't resolve the hostname #21421

Closed
stephendonner opened this issue Mar 2, 2022 · 2 comments

Comments

@stephendonner
Copy link

stephendonner commented Mar 2, 2022

Description

Clicking IPFS button from dweb.link shared audio doesn't resolve the hostname

Steps to Reproduce

  1. install 1.38.16
  2. launch Brave
  3. load ipns://ipfs.io
  4. click on Use a local Brave IPFS node
  5. load https://samplelib.com/sample-mp3.html
  6. context-click any audio file
  7. choose Import to IPFS > Selected audio
  8. select your file and confirm
  9. wait for the file to be shared
  10. paste your clipboard contents into the URL bar and press enter
  11. wait for your audio file to load/play
  12. click on the IPFS icon in the URL bar

You land on the following:

http://localhost:48081/ipns/bafybeidcvstdd2pkcyfri7ohymnp2gpslz2buomlnfg5z35e7atjre5xuy.ipfs.dweb.link/?filename=sample-15s.mp3

But you get thsi error:

ipfs resolve -r /ipns/bafybeidcvstdd2pkcyfri7ohymnp2gpslz2buomlnfg5z35e7atjre5xuy.ipfs.dweb.link/: could not resolve name

Actual result:

Clicking IPFS button from dweb.link shared audio doesn't resolve the hostname

example example example
ipfs-bug-2 ipfs-bug-3 ipfs-bug

Expected result:

Either the link is wrong and it should resolve, or we shouldn't offer the IPFS button

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.18 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 10 Version 21H2 (Build 19044.1566)

cc @lidel @spylogsster

@stephendonner
Copy link
Author

cc @MadhaviSeelam

@srirambv
Copy link
Contributor

srirambv commented Dec 5, 2022

This seems to be resolved now. Clicking on IPFS button from dweblink shared audio resolves the hostname correctly

21421.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants