Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default peeking card #21477

Closed
alexsafe opened this issue Mar 4, 2022 · 1 comment · Fixed by brave/brave-core#12489
Closed

Disable default peeking card #21477

alexsafe opened this issue Mar 4, 2022 · 1 comment · Fixed by brave/brave-core#12489

Comments

@alexsafe
Copy link

alexsafe commented Mar 4, 2022

Description

As per
https://bravesoftware.slack.com/archives/C0816QH3R/p1646406893336039?thread_ts=1646254593.006359&cid=C0816QH3R

News opt-in card is not shown by default. Instead it is available in Brave news Settings.

Steps to reproduce

  1. Go to Settings-Brave news
  2. Enable Brave news
  3. Close settings - Opt in card should show
  4. Click show news and news feed should appear

Few more cases/examples can be found via brave/brave-core#12489 (comment).

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

srirambv commented Mar 7, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.36.110
Clean Install

  • Verified on clean install there is no Brave News Opt-in peeking card is shown
  • Verified once enabling Brave News shows the opt-in card on the next NTP
  • Verified closing the opt-in card, and enabling show Brave News via settings enables the news feed on NTP

Upgrade Install

  • Verified upgrading from 1.35.102, doesn't show the opt-in card by default
  • Verified user is still enable to enable Brave news via Settings
  • Verified once Brave News is enabled, opt-in card is shown on NTP
  • Verified closing the opt-in card, and enabling show Brave News via settings enables the news feed on NTP
Clean Install Upgrade Install
21477-Clean.Install.mp4
21477-Upgrade.Install.mp4

Verification passed on Samsung Tab A with Android 10 running 1.36.110
Clean Install

  • Verified on clean install there is no Brave News Opt-in peeking card is shown
  • Verified once enabling Brave News shows the opt-in card on the next NTP
  • Verified closing the opt-in card, and enabling show Brave News via settings enables the news feed on NTP

Upgrade Install

  • Verified upgrading from 1.35.102, doesn't show the opt-in card by default
  • Verified user is still enable to enable Brave news via Settings
  • Verified once Brave News is enabled, opt-in card is shown on NTP
  • Verified closing the opt-in card, and enabling show Brave News via settings enables the news feed on NTP
Clean Install Upgrade Install
21477-Clean.Install.mp4
21477-Upgrade.Install.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants