Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields v2: No text/tooltip on hovering on the Shields icon #21581

Closed
Tonev opened this issue Mar 10, 2022 · 4 comments · Fixed by brave/brave-core#12523
Closed

Shields v2: No text/tooltip on hovering on the Shields icon #21581

Tonev opened this issue Mar 10, 2022 · 4 comments · Fixed by brave/brave-core#12523
Assignees
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@Tonev
Copy link
Contributor

Tonev commented Mar 10, 2022

Description

Hovering on the Shields icon doesn't show any text.

Steps to Reproduce

  1. Install Brave Nightly.
  2. Enable brave://flags/#brave-shields-v2 -> Relaunch.
  3. Open a random website, for example brave.com.
  4. Hover on the Shields icon.

Actual result:

brave_8Ai4iFBSNX

Expected result:

There should be a text on hover.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.32 Chromium: 99.0.4844.51 (Official Build) nightly (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Windows 7 Service Pack 1 (Build 7601)
@stephendonner stephendonner added feature/shields The overall Shields feature in Brave. feature/shields/panel Front-end design and functionality of the Shields panel. bug QA/Yes QA/Test-Plan-Specified labels Mar 10, 2022
@stephendonner stephendonner changed the title Shields v2: No text on hovering on the Shields icon Shields v2: No text/tooltip on hovering on the Shields icon Mar 10, 2022
@Tonev
Copy link
Contributor Author

Tonev commented Mar 14, 2022

@nullhook

Does brave/brave-core#12523 resolve this issue?

Particularly the following:

Added tooltip on the new shields icon

@nullhook
Copy link

nullhook commented Mar 14, 2022

Yes, resolves this also: #17369

@Tonev
Copy link
Contributor Author

Tonev commented Mar 14, 2022

Okay, thank you! You can add this issue as a keyword in your pull request so merging will automatically close it, too, if you like 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 30, 2022

Verified Passed using

Brave 1.38.74 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.556)
  • Install 1.38.74
  • Launched Brave
  • Enabled brave://flags/#brave-shields-v2
  • Enabled brave://flags/#brave-shields-v1
  • Clicked Relaunch
  • Both Shields displayed
  • Visited Brave.com
  • Hovered over v1 Shields icon and text displayed as Brave shields Want access to this site as expected
  • Hovered over v2 Shields and tooltip text displayed as Brave Shields
  • Disabled brave://flags/#brave-shields-v1 for v1 Shields
  • Only v2 Shields icon displayed
  • Visited Washingtonpost.com
  • Hovered over v2 Shields icon and text displayed as Brave Shields 19 Trackers, ads and more blocked
ex1 ex2 ex3
enabled both v1 and V2 shields v1v2 shields v1v2-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants