Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to launch x86-64 nightly build of CR100 on macOS #21743

Closed
stephendonner opened this issue Mar 17, 2022 · 4 comments
Closed

Unable to launch x86-64 nightly build of CR100 on macOS #21743

stephendonner opened this issue Mar 17, 2022 · 4 comments

Comments

@stephendonner
Copy link

stephendonner commented Mar 17, 2022

Description

Unable to launch x86-64 nightly build of CR100 on macOS (crashes and permissions dialogs)

Found while trying to test #21739

Steps to Reproduce

  1. download https://brave-jenkins-build-artifacts.s3.amazonaws.com/test-brave-browser-build-macos-x64/618/Brave-Browser-Nightly-x64.dmg
  2. double-click to extract
  3. run the installer
  4. launch Brave

Actual result:

example example
Screen Shot 2022-03-17 at 2 28 52 PM Screen Shot 2022-03-17 at 2 25 15 PM

Expected result:

No crash, and Brave launches

Reproduces how often:

100%

Brave version (brave://version info)

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? no

cc @kjozwiak @emerick @LaurenWags

@stephendonner
Copy link
Author

FWIW, it's also happening with https://brave-jenkins-build-artifacts.s3.amazonaws.com/test-brave-browser-build-macos-arm64/152/Brave-Browser-Nightly-arm64.dmg

@rebron rebron added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Mar 18, 2022
@stephendonner
Copy link
Author

@emerick did you want to close this one out with the info about the signing-key mishap?

@emerick emerick self-assigned this Mar 18, 2022
@emerick
Copy link
Contributor

emerick commented Mar 18, 2022

The QA test job for Mac was accidentally run with the "CI" keychain instead of the "Release" keychain, resulting in an invalidly signed app. @mkarolin reran the job with the correct keychain and we were good.

Will follow up with @mihaiplesa to see if it would make sense to make "Release" the default (or even only) choice.

@emerick emerick closed this as completed Mar 18, 2022
@emerick emerick added this to the 1.38.x - Nightly milestone Mar 18, 2022
@stephendonner
Copy link
Author

stephendonner commented Mar 21, 2022

Verified PASSED using

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.3 (Build 20G415)

and

Brave 1.38.60 Chromium: 100.0.4896.46 (Official Build) nightly (arm64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.4 (Build 20G417)

Confirmed able to launch without issue using both application binary and command-line, to execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants