Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item edit feature needs to be provided when same item (settings) is added multiple times #21751

Closed
GeetaSarvadnya opened this issue Mar 18, 2022 · 1 comment
Labels

Comments

@GeetaSarvadnya
Copy link

Description

Item edit feature needs to be provided when same item (settings) is added multiple times

Steps to Reproduce

  1. Clean profile 1.37.98
  2. Navigate to brave://settings
  3. Click on each side bare menu in the settings page and add each page to the sidebar
  4. Mouse hover on the added item in the sidebar
  5. Tooltip Settings is shown for each item instead of a particular page ( e.g brave://settings/getStarted, brave://settings/appearance)

Actual result:

image
sidebar_add settings

Expected result:

Item edit feature needs to be provided when same item (settings) is added multiple times

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.98 Chromium: 99.0.4844.74 (Official Build) beta (64-bit)
Revision fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS Windows 10 Version 21H2 (Build 19044.1586)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @simonhong

@rebron
Copy link
Collaborator

rebron commented Mar 18, 2022

I'm going to close this as a wontfix. I don't think we'll see folks adding Settings in the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants