The toggle of Auto-redirect AMP pages is visible inside other pages at brave://settings/privacy

[Tonev]

Description

The toggle of the new Auto-redirect AMP pages feature is currently visible in all other pages at the brave://settings/privacy section.

Steps to Reproduce

1. Install Brave Nightly.
2. Open brave://settings/privacy.
3. Open either of the following pages: Cookies and other site data, Security, Site and Shields Settings (the toggle will be visible in all site settings pages too).
4. Take a look at the right corner of the newly opened page, where the search functionality is located.

Actual result:

Clicking on the toggle will enable/disable Auto-redirect AMP pages feature at brave://settings/privacy.

Expected result:

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.38.57 Chromium: 99.0.4844.74 (Official Build) nightly (64-bit)
Revision	fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS	Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

CC: @ShivanKaul

[kjozwiak]

Reproduced on Win 11 x64 using the following build(s):

Brave | 1.38.57 Chromium: 99.0.4844.74 (Official Build) nightly (64-bit)
--- | ---
Revision | fee9a47e86e981802390cb0d41c5ed7ea93c4f6f-refs/branch-heads/4844@{#1060}
OS | Windows 11 Version 21H2 (Build 22000.556)

Brave | 1.38.62 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 11 Version 21H2 (Build 22000.556)

Example	Example	Example	Example

[Tonev]

@kjozwiak

Excuse me for the off-topic, but I have to ask since I'm not aware - is it already time for Auto-redirect AMP pages to be translated in other languages? The current issue is about the feature so I would like to know if I should open a follow up issue regarding my question. Thank you 👍

[kjozwiak]

Removing this from the 1.38.x milestone as it's still opened and not labelled as release/blocking. @ShivanKaul once brave/brave-core#12694 lands into master (which is 1.39.x now), you'll need to move this issue 1.39.x as well. We'll want to uplift into 1.38.x as well.

[kjozwiak]

@kjozwiak

Excuse me for the off-topic, but I have to ask since I'm not aware - is it already time for Auto-redirect AMP pages to be translated in other languages? The current issue is about the feature so I would like to know if I should open a follow up issue regarding my question. Thank you 👍

Believe we'll get translations for the above once we start doing translations for 1.38.x but I could be wrong. CCing @mkarolin @rebron who know a more about the translation process.

[kjozwiak]

Above will require 1.38.69 or newer for 1.38.x verification.

[stephendonner]

Verified PASSED using

Brave	1.38.70 Chromium: 100.0.4896.46 (Official Build) beta (x86_64)
Revision	5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS	macOS Version 11.6.5 (Build 20G527)

Confirmed Auto-redirect AMP pages toggle is in the right place, and works
Confirmed no more rogue De-amp pref entries

Settings	Cookies and other site data	Security	Site and Shields Settings