Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some strings are not translated on ads earnings messages #21895

Closed
btlechowski opened this issue Mar 26, 2022 · 1 comment
Closed

Some strings are not translated on ads earnings messages #21895

btlechowski opened this issue Mar 26, 2022 · 1 comment

Comments

@btlechowski
Copy link

btlechowski commented Mar 26, 2022

Follow up to #17133

Steps to Reproduce

  1. Run Brave in PL Polish locale
  2. Get an ad grant
  3. Check the messaging in Rewards settings page, NTP widget and BR panel

Actual result:

Some strings are not translated

Rewards settings page NTP widget BR panel
image image image

Expected result:

All strings are translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Verification passed on

Brave 1.37.101 Chromium: 99.0.4844.83 (Official Build) beta (64-bit)
Revision b11086e62d7c1a44b0942ac5568d22a425c7ae35-refs/branch-heads/4844_74@{#5}
OS Ubuntu 20 LTS

cc @brave/qa-team @rebron @mkarolin

@btlechowski
Copy link
Author

Verification passed on

Brave 1.37.109 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant