Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearance of Shields controls is dependent upon Rewards Icon being visible #21935

Closed
kaytwo opened this issue Mar 28, 2022 · 1 comment
Closed
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@kaytwo
Copy link

kaytwo commented Mar 28, 2022

Description

Appearance of Shields controls is dependent upon Rewards Icon being visible.

Steps to Reproduce

  1. Disable "Show Brave Rewards icon in address bar" setting
  2. Open a site where there should be a Shields icon
  3. Icon does not appear

Actual result:

If rewards is on, shields is visible. If rewards is off, shields is invisible (only share action visible on right edge of URL bar)

Expected result:

Shields should be visible & usable even if you disable the rewards icon.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Not broken yet on Current:

Brave 1.36.122 Chromium: 99.0.4844.88 (Official Build) (64-bit)
Revision 55132f110218a75dc6a4c2c20269efd6e3059177-refs/branch-heads/4844_73@{#2}
OS Windows 11 Version 21H2 (Build 22000.588)

Broken on Beta and Nightly:

Brave 1.38.67 Chromium: 100.0.4896.46 (Official Build) beta (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.588)
Brave 1.39.5 Chromium: 100.0.4896.46 (Official Build) nightly (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Windows 11 Version 21H2 (Build 22000.588)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    No
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A (Shields cannot be disabled when this bug happens)
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

@stephendonner
Copy link

Dupe of #21830

@stephendonner stephendonner added the closed/duplicate Issue has already been reported label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants