Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android VPN] [Beta User Feedback] Informative Persistent Notification #21997

Closed
timchilds opened this issue Mar 30, 2022 · 4 comments · Fixed by brave/brave-core#13640
Closed

Comments

@timchilds
Copy link

timchilds commented Mar 30, 2022

User 1 Feedback
First of all, it may be more descriptive and informative to write the country name, the amount of data received and sent in the notification showing that we are connected to the VPN on the main screen.

User 2 Feedback
Would be nice if the persistent notification of the VPN running in the background would bring you to the settings when you click on it. Similarly, you can enable/disable by hitting the 3 dots once, but have to press 2 more buttons to get into the settings (Settings, Brave Firewall + VPN).

User 3 Feedback
On this notification, it says that we are connected, it would be nice if we can also see the location of the server right from the notification

User 4 Feedback
The notification is meaningless, no information about how much data have been transmitted, which server you're connected to, and the icon can be confused with Brave Rewards ads

@kjozwiak
Copy link
Member

kjozwiak commented Jun 14, 2022

@deeppandya adding missing label as this issue is basically missing everything including the QA/Yes label. Adding the missing 1.41.x milestone as this was merged into 1.41.x so the appropriate milestone needs to be added. If this wasn't being uplifted, QA would never see the issue. Please see https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplifting.

@deeppandya
Copy link

@deeppandya adding missing label as this issue is basically missing everything including the QA/Yes label. Adding the missing 1.41.x milestone as this was merged into 1.41.x so the appropriate milestone needs to be added. If this wasn't being uplifted, QA would never see the issue. Please see https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplifting.

Thank you @kjozwiak I will keep it in mind. I created an uplift for it for 1.40.x so I think milestone should be 1.40.x

@kjozwiak
Copy link
Member

@deeppandya adding missing label as this issue is basically missing everything including the QA/Yes label. Adding the missing 1.41.x milestone as this was merged into 1.41.x so the appropriate milestone needs to be added. If this wasn't being uplifted, QA would never see the issue. Please see https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplifting.

Thank you @kjozwiak I will keep it in mind. I created an uplift for it for 1.40.x so I think milestone should be 1.40.x

For PRs, the milestone is always the same as the branch it landed into. So for example, in this case, brave/brave-core#13640 belongs in 1.41.x including the issue as the changes are currently only in 1.41.x. Once brave/brave-core#13716 gets uplifted by the uplift team, they'll change the issues milestone to 1.40.x as the changes are now in 1.40.x.

@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Verified as part of #22212 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants