Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search conversion promo's omnibox option #22616

Closed
simonhong opened this issue Apr 29, 2022 · 3 comments · Fixed by brave/brave-core#12846
Closed

Implement search conversion promo's omnibox option #22616

simonhong opened this issue Apr 29, 2022 · 3 comments · Fixed by brave/brave-core#12846

Comments

@simonhong
Copy link
Member

No description provided.

@stephendonner
Copy link

stephendonner commented Jun 22, 2022

Verified PASSED using

Brave 1.41.76 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

Button-type promo - PASSED

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed Try Brave Search button promo
  5. clicked on Try Brave Search button and confirmed it loaded https://search.brave.com/search?q=brunch&action=makeDefault
Dark Light Try Brave Search button
Screen Shot 2022-06-22 at 9 59 47 AM Screen Shot 2022-06-22 at 10 47 39 AM Screen Shot 2022-06-22 at 5 31 16 PM

Banner-type promo - PASSED

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxBanner command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed Try Brave Search banner promo
  5. click on Try Brave Search button and confirmed https://search.brave.com/search?q=brunch&action=makeDefault loaded
Dark Light Try Brave Search URL
Screen Shot 2022-06-22 at 9 57 37 AM Screen Shot 2022-06-22 at 9 57 21 AM Screen Shot 2022-06-22 at 5 29 26 PM

Private Browsing - PASSED

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner command-line switch
  6. confirmed no promotional banners appeared
button banner
Screen Shot 2022-06-22 at 10 55 12 AM Screen Shot 2022-06-22 at 10 58 11 AM

Private Browsing with Tor - PASSED

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner command-line switch
  6. confirmed no promotional banners appeared
button banner
Screen Shot 2022-06-22 at 10 50 00 AM Screen Shot 2022-06-22 at 10 51 52 AM

Guest - PASSED

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner
button banner
Screen Shot 2022-06-22 at 10 34 29 AM Screen Shot 2022-06-22 at 10 39 58 AM

User-keyword matching - PASSED

URL-visit/history precedence - PASSED

  1. install 1.41.76
  2. launch Brave
  3. load brave.com
  4. now, type brave.com but don't press return/enter
  5. confirm the 1st populated result in the URL bar is from the brave.com history entry from step 3
  6. confirm the 2nd populated result in the URL bar is the 🔍 brave - Brave Search
Screen Shot 2022-06-22 at 5 07 09 PM

promotional Brave Search entry - PASSED

  1. install 1.41.76
  2. launch Brave
  3. now, type brave.com but don't press return/enter
  4. confirm the 1st populated result in the URL bar is the promotional 🔍 brave.com - Brave Search entry
Screen Shot 2022-06-22 at 5 09 45 PM

Dismiss button / x widget - PASSED

Pre-requisite/setup:

  • run Button type and Banner type tests (separately)

(with a search for brunch already made)

Button:

  1. typed brunch again
  2. clicked on x to dismiss the button promo
  3. typed brunch again
  4. confirmed no promo shown
  5. typed dinner
  6. confirmed no promo shown
x widget brunch search dinner search
Screen Shot 2022-06-22 at 2 59 28 PM Screen Shot 2022-06-22 at 2 59 40 PM Screen Shot 2022-06-22 at 2 59 47 PM

Banner:

  1. typed brunch again
  2. clicked on Dismiss to dismiss the button promo
  3. typed brunch again
  4. confirmed no promo shown
  5. typed dinner
  6. confirmed no promo shown
Dismiss button brunch search dinner search
Screen Shot 2022-06-22 at 2 41 31 PM Screen Shot 2022-06-22 at 3 10 42 PM Screen Shot 2022-06-22 at 3 10 45 PM

Repeat-matching input - PASSED

Pre-requisite/setup:

  • run Button type and Banner type tests (separately)
  1. typed brunch
  2. clicked on Try Brave Search
  3. confirmed https://search.brave.com/search?q=brunch&action=makeDefault loads
  4. typed brunch again
  5. confirmed the promotional button/banner was removed
  6. confirmed the search showed up in autocomplete history
brunch - button brunch - banner
Screen Shot 2022-06-22 at 11 20 24 AM Screen Shot 2022-06-22 at 11 17 37 AM

Also confirmed that changing the search term brings the promotions back.

brunchy - button brunc - banner
Screen Shot 2022-06-22 at 11 23 51 AM Screen Shot 2022-06-22 at 11 28 31 AM

Promo-enabled countries - PASSED

CA

button banner
Screen Shot 2022-06-22 at 11 43 09 AM Screen Shot 2022-06-22 at 11 44 56 AM

DE

button banner
Bildschirmfoto 2022-06-22 um 12 27 50 Bildschirmfoto 2022-06-22 um 12 28 47

FR

button banner
Capture d’écran 2022-06-22 à 12 17 24 Capture d’écran 2022-06-22 à 12 18 12

GB

button banner
Screenshot 2022-06-22 at 12 33 32 Screenshot 2022-06-22 at 12 38 48

Non promo-enabled countries - PASSED

ES

button banner
Captura de pantalla 2022-06-22 a las 11 55 02 Captura de pantalla 2022-06-22 a las 11 55 52

AU

button banner
Screen Shot 2022-06-22 at 12 02 36 pm Screen Shot 2022-06-22 at 12 03 22 pm

IN

button banner
Screenshot 2022-06-22 at 12 09 41 PM Screenshot 2022-06-22 at 12 10 31 PM

Logged:
#23607

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 23, 2022
@stephendonner
Copy link

stephendonner commented Jun 28, 2022

Verification PASSED using

Brave 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS Linux

Button-type promo - PASSED

  1. installed 1.41.82
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Startpage
  4. typed typical search term and confirmed Try Brave Search button promo
  5. clicked on Try Brave Search button and confirmed it loaded https://search.brave.com/search?q=brunch&action=makeDefault
Dark Light Try Brave Search button
Screen Shot 2022-06-28 at 3 58 56 PM Screen Shot 2022-06-28 at 3 59 11 PM Screen Shot 2022-06-28 at 4 00 51 PM

Banner-type promo - PASSED

  1. installed 1.41.82
  2. launched Brave using --enable-features=BraveSearchOmniboxBanner command-line switch
  3. set Search engine used in the address bar to Startpage
  4. typed brunch and confirmed Try Brave Search banner promo
  5. click on Try Brave Search button and confirmed https://search.brave.com/search?q=brunch&action=makeDefault loaded
Dark Light Try Brave Search URL
Screen Shot 2022-06-28 at 4 30 49 PM Screen Shot 2022-06-28 at 4 30 31 PM Screen Shot 2022-06-28 at 4 31 00 PM

Private Browsing - PASSED

  1. installed 1.41.82
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Startpage
  4. typed typical search term and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner command-line switch
  6. confirmed no promotional banners appeared
button banner
Screen Shot 2022-06-28 at 4 38 29 PM Screen Shot 2022-06-28 at 4 39 36 PM

Private Browsing with Tor - PASSED

  1. installed 1.41.82
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Startpage
  4. typed typical search term and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner command-line switch
  6. confirmed no promotional banners appeared
button banner
Screen Shot 2022-06-28 at 4 55 03 PM Screen Shot 2022-06-28 at 4 56 47 PM

Guest - PASSED

  1. installed 1.41.82
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Startpage
  4. typed typical search term and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner
button banner
Screen Shot 2022-06-28 at 5 07 09 PM Screen Shot 2022-06-28 at 5 08 36 PM

User-keyword matching - PASSED

URL-visit/history precedence - PASSED

  1. install 1.41.82
  2. launch Brave
  3. load brave.com
  4. now, type brave.com but don't press return/enter
  5. confirm the 1st populated result in the URL bar is from the brave.com history entry from step 3
  6. confirm the 2nd populated result in the URL bar is the 🔍 brave - Brave Search
Screen Shot 2022-06-28 at 5 16 30 PM

promotional Brave Search entry - PASSED

  1. install 1.41.82
  2. launch Brave
  3. now, type brave.com but don't press return/enter
  4. confirm the 1st populated result in the URL bar is the promotional 🔍 brave.com - Brave Search entry
Screen Shot 2022-06-28 at 5 17 38 PM

Dismiss button / x widget - PASSED

Pre-requisite/setup:

  • run Button type and Banner type tests (separately)

Button:

  1. typed brunch again
  2. clicked on x to dismiss the button promo
  3. typed brunch again
  4. confirmed no promo shown
  5. typed dinner
  6. confirmed no promo shown
x widget brunch search dinner search
Screen Shot 2022-06-28 at 5 27 59 PM Screen Shot 2022-06-28 at 5 26 22 PM Screen Shot 2022-06-28 at 5 26 35 PM

Banner:

  1. typed brunch again
  2. clicked on Dismiss to dismiss the button promo
  3. typed brunch again
  4. confirmed no promo shown
  5. typed dinner
  6. confirmed no promo shown
Dismiss button brunch search dinner search
Screen Shot 2022-06-28 at 5 31 33 PM Screen Shot 2022-06-28 at 5 32 05 PM Screen Shot 2022-06-28 at 5 32 10 PM

Repeat-matching input - PASSED

Pre-requisite/setup:

  • run Button type and Banner type tests (separately)
  1. typed brunch
  2. clicked on Try Brave Search
  3. confirmed https://search.brave.com/search?q=brunch&action=makeDefault loads
  4. typed brunch again
  5. confirmed the promotional button/banner was removed
  6. confirmed the search showed up in autocomplete history
brunch - button brunch - banner
Screen Shot 2022-06-28 at 5 50 37 PM Screen Shot 2022-06-28 at 5 52 00 PM

Also confirmed that changing the search term brings the promotions back.

brunchy - button brunchy - banner
Screen Shot 2022-06-28 at 5 46 45 PM Screen Shot 2022-06-28 at 5 46 02 PM

Promo-enabled countries - PASSED

CA - Canada

button banner
Screen Shot 2022-06-29 at 12 04 01 AM Screen Shot 2022-06-29 at 12 04 53 AM

DE - Germany

button banner
Screen Shot 2022-06-28 at 11 33 46 PM Screen Shot 2022-06-28 at 11 34 34 PM

FR - France

button banner
Screen Shot 2022-06-28 at 11 40 51 PM Screen Shot 2022-06-28 at 11 41 54 PM

GB - (Great Britain) United Kingdom

button banner
Screen Shot 2022-06-28 at 11 58 45 PM Screen Shot 2022-06-28 at 11 57 13 PM

Non promo-enabled countries - PASSED

UA - Ukraine

button banner
Screen Shot 2022-06-28 at 6 16 31 PM Screen Shot 2022-06-28 at 6 18 39 PM

RU - Russia

button banner
Screen Shot 2022-06-28 at 7 14 56 PM Screen Shot 2022-06-28 at 7 12 37 PM

Logged:
#23607

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 28, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 30, 2022

Verification PASSED using

Brave | 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
-- | --
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Windows 11 Version 21H2 (Build 22000.739)

Filed #23815

Test Case 1: Button-type promo - PASSED

Case 1: Button-type promo - PASSED

  1. installed 1.41.86
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. go to brave://settings/search and set Search engine used in the address bar to Qwant
  4. typed social and confirmed Try Brave Search button promo is visible as a second item
  5. clicked on Try Brave Search button and confirmed it loaded https://search.brave.com/search?q=social&action=makeDefault

Dark

Step 3 Step 4 Step 5
step 3 step 4 step 3

Light

Step 3 Step 4 Step 5
step 3 step 3 step 3

Case 2: Repeat -matching input - PASSED

  1. Run steps 1-3 from Case 1
  2. typed coconut and clicked Try Brave Search button promo
  3. confirmed it loaded `https://search.brave.com/search?q=coconut&action=makeDefault
  4. typed coconut again
  5. confirmed the promotional button was removed
  6. confirmed the search showed up in autocomplete history
Step 3 Step 4 Step 5&6
image image image

Case 3: Button-type promo - x widget - PASSED

  1. Run steps from 1-4 from Test Case 1
  2. clicked on x to dismiss the button promo
  3. typed app again
  4. confirmed no promo shown
  5. typed globe in another tab
  6. confirmed no promo shown
Step 2 Step 2A Step 5 Step 7
image image image image

Test Case 2: Banner-type promo - PASSED

Case 1: Banner-type promo - PASSED

  1. new profile
  2. launched Brave using --enable-features=BraveSearchOmniboxBanner command-line switch
  3. go to brave://settings/search and set Search engine used in the address bar to Bing
  4. typed bb and confirmed Try Brave Search banner promo and is visible as a last item
  5. click on Try Brave Search button and confirmed https://search.brave.com/search?q=brunch&action=makeDefault loaded

Light

Step 3 Step 4 Step 5
step 3 step 3 step 3

Dark

Step 3 Step 4 Step 5
step 3 step 3 step 3

Case 2: Repeat -matching input - PASSED

  1. Run steps 1-3 from Case 1
  2. typed starbucks and clicked Try Brave Search banner promo
  3. confirmed it loaded `https://search.brave.com/search?q=starbucks&action=makeDefault
  4. typed starbucks again
  5. confirmed the promotional banner was removed
  6. confirmed the search showed up in autocomplete history
Step 2 Step 3 Step 6
image image image

Case 3: Banner-type promo: Dismiss - PASSED

  1. Run steps from 1-4 from Test Case 2
  2. clicked Dismiss to dismiss the banner promo
  3. typed bb again
  4. confirmed no promo shown
  5. typed pin
  6. confirmed no promo shown
Step 2 Step 2A Step 3 Step 5
image image image image

Test Case 3: User-keyword matching - PASSED

Case 1: URL-visit/history precedence with brave as a default provider- PASSED

  1. new profile
  2. launch Brave
  3. load a url nytimes.com
  4. now, type nytimes.com but don't press return/enter
  5. confirm the 1st populated result in the URL bar is from the nytimes.com history entry from step 3
  6. confirm the 2nd populated result in the URL bar is the 🔍 nytimes.com- Brave Search
image

Case 2: Promotional Brave Search entry - PASSED

  1. new profile
  2. launch Brave
  3. now, type brave.com but don't press return/enter
  4. confirm the 1st populated result in the URL bar is the promotional 🔍 brave.com - Brave Search entry
image

Case 3: Promotion is not visible for URL-visit when brave NOT as a default search provider- PASSED

  1. Run steps 1-3 from Case 1
  2. type URL nytimes.com
  3. confirmed the promotional button/banner is not visible
  4. confirm the 1st populated result in the URL bar is the promotional 🔍 nytimes.com - Qwant Search entry
  5. type another url yahoo.com in another tab
  6. confirmed the promotional button/banner is not visible
Step 2 Step 4
image image

Test Case 4: Private Browsing with Tor - PASSED

  1. new profile
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to Startpage
  4. typed kayak and confirmed NO Try Brave Search banner promo
  5. repeated the above with --enable-features=BraveSearchOmniboxBanner command-line switch
  6. confirmed no promotional banners appeared

Button Promo

Normal Window Private Browsing with TOR
image image

Banner promo

Normal Window Private Browsing with TOR
image image

Test Case 5: Private Window- PASSED

1.new profile
2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
3. set Search engine used in the address bar to Google
4. typed boating and confirmed NO Try Brave Search banner promo
5. repeated the above with --enable-features=BraveSearchOmniboxBanner

Button Promo

Normal Window Private Window
image image

Banner promo

Normal Window Private Window
image image

Test Case 6: Promo-enabled countries - PASSED

CA - Canada

search button banner
image image image

DE- Germany

button banner
image image

FR - France

button banner
image image

GB - (Great Britain) United Kingdom

button banner
image image

Test Case 7 - Non promo-enabled countries - PASSED

AU - Australia

button banner
image image

BR - Brazil

button banner
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment