-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement search conversion promo's omnibox option #22616
Comments
Verified
|
Brave | 1.41.76 Chromium: 103.0.5060.53 (Official Build) beta (x86_64) |
---|---|
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853} |
OS | macOS Version 11.6.7 (Build 20G630) |
Button-type promo - PASSED
- installed
1.41.76
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toEcosia
- typed
brunch
and confirmedTry Brave Search
button promo - clicked on
Try Brave Search
button and confirmed it loadedhttps://search.brave.com/search?q=brunch&action=makeDefault
Dark |
Light |
Try Brave Search button |
---|---|---|
Banner-type promo - PASSED
- installed
1.41.76
- launched Brave using
--enable-features=BraveSearchOmniboxBanner
command-line switch - set
Search engine used in the address bar
toEcosia
- typed
brunch
and confirmedTry Brave Search
banner promo - click on
Try Brave Search
button and confirmedhttps://search.brave.com/search?q=brunch&action=makeDefault
loaded
Dark |
Light |
Try Brave Search URL |
---|---|---|
Private Browsing - PASSED
- installed
1.41.76
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toEcosia
- typed
brunch
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
command-line switch - confirmed no promotional banners appeared
button | banner |
---|---|
Private Browsing with Tor - PASSED
- installed
1.41.76
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toEcosia
- typed
brunch
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
command-line switch - confirmed no promotional banners appeared
button | banner |
---|---|
Guest - PASSED
- installed
1.41.76
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toEcosia
- typed
brunch
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
button | banner |
---|---|
User-keyword matching - PASSED
URL-visit/history precedence - PASSED
- install
1.41.76
- launch Brave
- load
brave.com
- now, type
brave.com
but don't pressreturn
/enter
- confirm the 1st populated result in the URL bar is from the
brave.com
history entry from step 3 - confirm the 2nd populated result in the URL bar is the
🔍 brave - Brave Search
promotional Brave Search entry - PASSED
- install
1.41.76
- launch Brave
- now, type
brave.com
but don't pressreturn
/enter
- confirm the 1st populated result in the URL bar is the promotional
🔍 brave.com - Brave Search
entry
Dismiss button / x
widget - PASSED
Pre-requisite/setup:
- run
Button type
andBanner type
tests (separately)
(with a search for brunch
already made)
Button:
- typed
brunch
again - clicked on
x
to dismiss the button promo - typed
brunch
again - confirmed no promo shown
- typed
dinner
- confirmed no promo shown
x widget |
brunch search |
dinner search |
---|---|---|
Banner:
- typed
brunch
again - clicked on
Dismiss
to dismiss the button promo - typed
brunch
again - confirmed no promo shown
- typed
dinner
- confirmed no promo shown
Dismiss button |
brunch search |
dinner search |
---|---|---|
Repeat-matching input - PASSED
Pre-requisite/setup:
- run
Button type
andBanner type
tests (separately)
- typed
brunch
- clicked on
Try Brave Search
- confirmed
https://search.brave.com/search?q=brunch&action=makeDefault
loads - typed
brunch
again - confirmed the promotional button/banner was removed
- confirmed the search showed up in autocomplete history
brunch - button |
brunch - banner |
---|---|
Also confirmed that changing the search term brings the promotions back.
brunchy - button |
brunc - banner |
---|---|
Promo-enabled countries - PASSED
Non promo-enabled countries - PASSED
Logged:
#23607
Verification
|
Brave | 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit) |
---|---|
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066} |
OS | Linux |
Button-type promo - PASSED
- installed
1.41.82
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toStartpage
- typed
typical search term
and confirmedTry Brave Search
button promo - clicked on
Try Brave Search
button and confirmed it loadedhttps://search.brave.com/search?q=brunch&action=makeDefault
Dark |
Light |
Try Brave Search button |
---|---|---|
Banner-type promo - PASSED
- installed
1.41.82
- launched Brave using
--enable-features=BraveSearchOmniboxBanner
command-line switch - set
Search engine used in the address bar
toStartpage
- typed
brunch
and confirmedTry Brave Search
banner promo - click on
Try Brave Search
button and confirmedhttps://search.brave.com/search?q=brunch&action=makeDefault
loaded
Dark |
Light |
Try Brave Search URL |
---|---|---|
Private Browsing - PASSED
- installed
1.41.82
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toStartpage
- typed
typical search term
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
command-line switch - confirmed no promotional banners appeared
button | banner |
---|---|
Private Browsing with Tor - PASSED
- installed
1.41.82
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toStartpage
- typed
typical search term
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
command-line switch - confirmed no promotional banners appeared
button | banner |
---|---|
Guest - PASSED
- installed
1.41.82
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toStartpage
- typed
typical search term
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
button | banner |
---|---|
User-keyword matching - PASSED
URL-visit/history precedence - PASSED
- install
1.41.82
- launch Brave
- load
brave.com
- now, type
brave.com
but don't pressreturn
/enter
- confirm the 1st populated result in the URL bar is from the
brave.com
history entry from step 3 - confirm the 2nd populated result in the URL bar is the
🔍 brave - Brave Search
promotional Brave Search entry - PASSED
- install
1.41.82
- launch Brave
- now, type
brave.com
but don't pressreturn
/enter
- confirm the 1st populated result in the URL bar is the promotional
🔍 brave.com - Brave Search
entry
Dismiss button / x
widget - PASSED
Pre-requisite/setup:
- run
Button type
andBanner type
tests (separately)
Button:
- typed
brunch
again - clicked on
x
to dismiss the button promo - typed
brunch
again - confirmed no promo shown
- typed
dinner
- confirmed no promo shown
x widget |
brunch search |
dinner search |
---|---|---|
Banner:
- typed
brunch
again - clicked on
Dismiss
to dismiss the button promo - typed
brunch
again - confirmed no promo shown
- typed
dinner
- confirmed no promo shown
Dismiss button |
brunch search |
dinner search |
---|---|---|
Repeat-matching input - PASSED
Pre-requisite/setup:
- run
Button type
andBanner type
tests (separately)
- typed
brunch
- clicked on
Try Brave Search
- confirmed
https://search.brave.com/search?q=brunch&action=makeDefault
loads - typed
brunch
again - confirmed the promotional button/banner was removed
- confirmed the search showed up in autocomplete history
brunch - button |
brunch - banner |
---|---|
Also confirmed that changing the search term brings the promotions back.
brunchy - button |
brunchy - banner |
---|---|
Promo-enabled countries - PASSED
CA
- Canada
button | banner |
---|---|
DE
- Germany
button | banner |
---|---|
FR
- France
button | banner |
---|---|
GB
- (Great Britain) United Kingdom
button | banner |
---|---|
Non promo-enabled countries - PASSED
Logged:
#23607
Verification
Filed #23815 Test Case 1: Button-type promo - PASSEDCase 1: Button-type promo -
|
Step 3 | Step 4 | Step 5 |
---|---|---|
Light
Step 3 | Step 4 | Step 5 |
---|---|---|
Case 2: Repeat -matching input - PASSED
- Run steps 1-3 from Case 1
- typed
coconut
and clickedTry Brave Search
button promo - confirmed it loaded `https://search.brave.com/search?q=coconut&action=makeDefault
- typed
coconut
again - confirmed the promotional button was removed
- confirmed the search showed up in autocomplete history
Step 3 | Step 4 | Step 5&6 |
---|---|---|
Case 3: Button-type promo - x
widget - PASSED
- Run steps from 1-4 from Test Case 1
- clicked on
x
to dismiss the button promo - typed
app
again - confirmed no promo shown
- typed
globe
in another tab - confirmed no promo shown
Step 2 | Step 2A | Step 5 | Step 7 |
---|---|---|---|
Test Case 2: Banner-type promo - PASSED
Case 1: Banner-type promo - PASSED
- new profile
- launched Brave using
--enable-features=BraveSearchOmniboxBanner
command-line switch - go to brave://settings/search and set
Search engine used in the address bar
toBing
- typed
bb
and confirmedTry Brave Search
banner promo and is visible as a last item - click on
Try Brave Search
button and confirmedhttps://search.brave.com/search?q=brunch&action=makeDefault
loaded
Light
Step 3 | Step 4 | Step 5 |
---|---|---|
Dark
Step 3 | Step 4 | Step 5 |
---|---|---|
Case 2: Repeat -matching input - PASSED
- Run steps 1-3 from Case 1
- typed
starbucks
and clickedTry Brave Search
banner promo - confirmed it loaded `https://search.brave.com/search?q=starbucks&action=makeDefault
- typed
starbucks
again - confirmed the promotional banner was removed
- confirmed the search showed up in autocomplete history
Step 2 | Step 3 | Step 6 |
---|---|---|
Case 3: Banner-type promo: Dismiss
- PASSED
- Run steps from 1-4 from Test Case 2
- clicked
Dismiss
to dismiss the banner promo - typed
bb
again - confirmed no promo shown
- typed
pin
- confirmed no promo shown
Step 2 | Step 2A | Step 3 | Step 5 |
---|---|---|---|
Test Case 3: User-keyword matching - PASSED
Case 1: URL-visit/history precedence with brave as a default provider- PASSED
- new profile
- launch Brave
- load a url
nytimes.com
- now, type
nytimes.com
but don't pressreturn
/enter
- confirm the 1st populated result in the URL bar is from the
nytimes.com
history entry from step 3 - confirm the 2nd populated result in the URL bar is the
🔍 nytimes.com- Brave Search
Case 2: Promotional Brave Search entry - PASSED
- new profile
- launch Brave
- now, type
brave.com
but don't pressreturn
/enter
- confirm the 1st populated result in the URL bar is the promotional
🔍 brave.com - Brave Search
entry
Case 3: Promotion is not visible for URL-visit
when brave NOT as a default search provider- PASSED
- Run steps 1-3 from Case 1
- type URL
nytimes.com
- confirmed the promotional button/banner is not visible
- confirm the 1st populated result in the URL bar is the promotional
🔍 nytimes.com - Qwant Search
entry - type another url
yahoo.com
in another tab - confirmed the promotional button/banner is not visible
Step 2 | Step 4 |
---|---|
Test Case 4: Private Browsing with Tor - PASSED
- new profile
- launched Brave using
--enable-features=BraveSearchOmniboxButton
command-line switch - set
Search engine used in the address bar
toStartpage
- typed
kayak
and confirmed NOTry Brave Search
banner promo - repeated the above with
--enable-features=BraveSearchOmniboxBanner
command-line switch - confirmed no promotional banners appeared
Button Promo
Normal Window | Private Browsing with TOR |
---|---|
Banner promo
Normal Window | Private Browsing with TOR |
---|---|
Test Case 5: Private Window- PASSED
1.new profile
2. launched Brave using --enable-features=BraveSearchOmniboxButton
command-line switch
3. set Search engine used in the address bar
to Google
4. typed boating
and confirmed NO Try Brave Search
banner promo
5. repeated the above with --enable-features=BraveSearchOmniboxBanner
Button Promo
Normal Window | Private Window |
---|---|
Banner promo
Normal Window | Private Window |
---|---|
Test Case 6: Promo-enabled countries - PASSED
CA
- Canada
search | button | banner |
---|---|---|
DE- Germany
button | banner |
---|---|
FR - France
button | banner |
---|---|
GB
- (Great Britain) United Kingdom
button | banner |
---|---|
No description provided.
The text was updated successfully, but these errors were encountered: