Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiry date should specify if its for trial or for subscription #23004

Closed
srirambv opened this issue May 23, 2022 · 3 comments · Fixed by brave/brave-core#13641
Closed

Expiry date should specify if its for trial or for subscription #23004

srirambv opened this issue May 23, 2022 · 3 comments · Fixed by brave/brave-core#13641

Comments

@srirambv
Copy link
Contributor

Description

Expiry date should specify if its for trial or for subscription

Steps to reproduce

  1. Purchase a monthly subscription
  2. Go to VPN Settings
  3. Shows Expiry in 7 days which is the trial expiry not the actual subscription expiry

Actual result

Expected result

Specify the expiry is for Trial or subcsription

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? N/A
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.39.111

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @deeppandya @Uni-verse @kjozwiak

@kjozwiak
Copy link
Member

kjozwiak commented Jun 8, 2022

Adding missing 1.41.x milestone as this was merged into master via brave/brave-core#13641 which is currently 1.41.x.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 8, 2022

The above will require 1.39.120 or higher for 1.39.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 8, 2022

Verification PASSED on Samsung Galaxy S21 & Galaxy Tab S7 devices using

Brave	1.39.120 Chromium: 102.0.5005.99 (Official Build) (64-bit) 
Revision	870f7bcc58dfa811cc68c2186439721385e086d0-refs/branch-heads/5005@{#1125}
OS	Android 12; Build/SP1A.210812.016
  • Verified Status in VPN settings is correctly displaying subscriptions based on the type (Trial/Monthly/Yearly)
  • Verified trial type subscription are not displayed if user re-subs when subscriptions expires.
  • Verified Monthly subscription and Yearly subscription are displayed under VPN Status based
Monthly Yearly Trial (Tablet) Trial (Mobile)
screenshot-1654709447550 screenshot-1654711372635 screenshot-1654715548807 screenshot-1654715586168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants