Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Ads should persist timestamps using ToDeltaSinceWindowsEpoch and FromDeltaSinceWindowsEpoch in Microseconds #23087

Closed
tmancey opened this issue May 26, 2022 · 1 comment · Fixed by brave/brave-core#18454
Closed

Brave Ads should persist timestamps using ToDeltaSinceWindowsEpoch and FromDeltaSinceWindowsEpoch in Microseconds #23087

tmancey opened this issue May 26, 2022 · 1 comment · Fixed by brave/brave-core#18454
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented May 26, 2022 •
edited
Loading

Brave Ads should persist timestamps using ToDeltaSinceWindowsEpoch and FromDeltaSinceWindowsEpoch in Microseconds and not as Double. Existing values will need to be migrated from double columns to string columns
@tmancey tmancey self-assigned this May 11, 2023
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels May 11, 2023
@tmancey tmancey mentioned this issue May 11, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 12, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#18454

Verified notification ad was shown after upgrade from 1.50.x

Verified ntp si was served after upgrade from 1.50.x

Verified Brave news inline ad was shown after upgrade from 1.50.x

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.56.x - Release
3 participants
@tmancey @btlechowski @brave-builds