Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to remove Top Tiles from NTP #23118

Closed
anthonypkeane opened this issue May 27, 2022 · 5 comments · Fixed by brave/brave-core#13519
Closed

Provide an option to remove Top Tiles from NTP #23118

anthonypkeane opened this issue May 27, 2022 · 5 comments · Fixed by brave/brave-core#13519
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@anthonypkeane
Copy link

Description

This person makes a fair point here,

Let's provide an option to remove Top Tiles from NTP.

Settings details TBD @timchilds

@anthonypkeane anthonypkeane added priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality needs-more-info The report requires more detail before we can decide what to do with this issue. labels May 27, 2022
@anthonypkeane
Copy link
Author

Related to: #22921

@kjozwiak
Copy link
Member

@brave/qa-team please see the STR/Cases that I created/went through via brave/brave-core#13519 (comment) when verifying via 1.40.x 👍

@kjozwiak kjozwiak added release-notes/include and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Jun 15, 2022
@kjozwiak
Copy link
Member

The above will require 1.40.100 or higher for 1.40.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 16, 2022

Verification in progress using

Brave	1.40.101 Chromium: 103.0.5060.42 (Official Build) (32-bit) 
Revision	de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS	Android 12; Build/SP1A.210812.016

Referred to brave/brave-core#13519 (comment) as a basis for the test plan

Clean Profile:

  • ensured that the Top Tiles being displayed under NTP on a clean install (you'll need to open a second tab due known issue)
  • ensured that Show Top sites is enabled by default via Settings -> New Tab Page`
  • ensured that the Top Tiles is displayed under the NTP after several restarts
  • ensured that the Top Tiles are removed from NTP when disabled via Settings -> New Tab Page
  • ensured that Top Tiles isn't visible after opening several NTP after being disabled
  • ensured that Top Tiles isn't visible after restarting the browser several times after being disabled
  • ensured there's no obvious issues when going between portrait & horizontal modes while Top Tiles are disabled
  • ensured that Brave still remembers the most popular websites and still populates Top Tiles even though disabled
  • Example: Disable Top Tiles, visit several websites and than re-enable (they should be appearing via the Top Tiles
  • ensured that all the context menu's are working as expected after Disabling and than Enabling the Top Tiles
  • Open in new tab in group, Open in Private tab, Open in other window, Download link, Remove
  • ensured that Top Tiles are still visible/working when both Show Background Images & Sponsored Images are disabled
  • ensured that two rows are being displayed when both Show Background Images & Sponsored Images are disabled
  • ensured that Top Tiles can be disabled when both Show Background Images & Sponsored Images are disabled

Upgrade:

Case: Upgrade from app version that doesn't support feature

  • downloaded/installed 1.39.120 Chromium: 102.0.5005.99
  • ensured that Show Top sites is not visible/available under Settings -> New Tab Page
  • Upgraded to 1.40.101 Chromium: 103.0.5060.42
  • ensured that Top Tiles are still visible under NTP
  • ensured that Show Top sites is enabled via Settings -> New Tab Page

Known related issues: #23474

Example Example Example Example Example
screenshot-1655422379551 screenshot-1655422473055 screenshot-1655422483280 screenshot-1655422716627 screenshot-1655422746389
screenshot-1655424776166 screenshot-1655424810941 screenshot-1655424833082 screenshot-1655425074895 screenshot-1655425133615

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 17, 2022
@Uni-verse
Copy link
Contributor

@Uni-verse Check below case when next release build is available.

Case:

  • downloaded/installed 1.40.x build with feature
  • disabled Show Top sites from Settings -> New Tab Page and restarted re-launched the browser as specified
  • Upgraded 1.40.x app
  • ensured that Top Top tiles are not being displayed under NTP
  • ensured that Show Top sites is disabled via Settings -> New Tab Page

@Uni-verse Uni-verse added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants