Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from C102 -> C103 on macOS x64 via 1.41.x - Nightly (Checking C103) #23374

Closed
30 of 33 tasks
LaurenWags opened this issue Jun 9, 2022 · 2 comments
Closed
30 of 33 tasks

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jun 9, 2022

As per process, QA runs through the following cases to ensure that the major chromium bump that's about to get merged into master doesn't regress the Nightly channel. Once the major chromium bump is merged into master, QA will run through a full manual pass on Windows & Android.

Startup & Components

  • Verify that Brave is only contacting *.brave.com endpoints on first launch using either Charles Proxy, Fiddler, Wireshark or LittleSnitch (or a similar application)
    • Verify that opening a NTP doesn't trigger any outbound connections related to widgets without user interaction
  • Remove the following component folders and ensure that they're being re-downloaded after restarting the browser:
    • afalakplffnnnlkncjhbmahjfjhmlkal: AutoplayWhitelist.dat, ExtensionWhitelist.dat, ReferrerWhitelist.json and Greaselion.json
    • CertificateRevocation
    • cffkpbalmllkdoenhmdmpbkajipdjfam: rs-ABPFilterParserData.dat & regional_catalog.json (AdBlock)
    • gccbbckogglekeggclmmekihdgdpdgoe: (Sponsored New Tab Images)
    • jicbkmdloagakknpihibphagfckhjdih: speedreader-updater.dat
    • oofiananboodjbbmdelgdommihjbkfag: HTTPSE
    • Safe Browsing
  • Restart the browser, load brave://components, wait for 8 mins and verify that no component shows any errors

Note: Always double check brave://components to make sure there's no errors/missing version numbers. We basically want to make sure that components are working as they regressed in C98 when we first merged into master.

Upgrade

  • Make sure that data from the last version appears in the new version OK
  • Ensure that brave://version lists the expected Brave & Chromium versions
  • With data from the last version, verify that:
    • Bookmarks on the bookmark toolbar and bookmark folders can be opened
    • Cookies are preserved
    • Installed extensions are retained and work correctly
    • Opened tabs can be reloaded
    • Stored passwords are preserved
    • Sync chain created in previous version is retained
    • Social media-blocking buttons changes are retained
    • Rewards
      • Wallet balance is retained
      • Auto-contribute list is retained
      • Both Tips and Monthly Contributions are retained
      • Wallet panel transactions list is retained
      • Changes to rewards settings are retained
      • Ensure that Auto Contribute is not being enabled when upgrading to a new version if AC was disabled
    • Ads
      • Both Estimated pending rewards & Ad notifications received this month are retained
      • Changes to ads settings are retained
      • Ensure that ads are not being enabled when upgrading to a new version if they were disabled
      • Ensure that ads are not disabled when upgrading to a new version if they were enabled
@LaurenWags
Copy link
Member Author

Build from https://bravesoftware.slack.com/archives/CU5UXM3EC/p1654801946443229?thread_ts=1654801940.046659&cid=CU5UXM3EC used for above tests:

Brave | 1.41.49 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | macOS Version 12.4 (Build 21F79)

@LaurenWags
Copy link
Member Author

Logged #23383 for Ads per hour setting not being retained on upgrade, however it is not specific to Chromium 103 build of 1.41.x, it also reproduces with Chromium 102 version of 1.41.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant