Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to Send ERC721 tokens #23508

Closed
srirambv opened this issue Jun 16, 2022 · 3 comments · Fixed by brave/brave-core#13532
Closed

Unable to Send ERC721 tokens #23508

srirambv opened this issue Jun 16, 2022 · 3 comments · Fixed by brave/brave-core#13532
Assignees
@srirambv
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 16, 2022 •
edited
Loading

Description

Unable to Send ERC721 tokens

Steps to reproduce

  1. Add an ERC721 token to portfolio
  2. Select send on quick action button
  3. Select the account which has the ERC721 token associated to
  4. Select token dropdown, no ERC721 token is shown to select to send

Actual result

Unable to Send ERC721 tokens

Expected result

Should be able to send ERC721 tokens similar to desktop

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.40.101 RC build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @wchen342 @SergeyZhukovsky @Pavneet-Sing @jamesmudgett
@srirambv srirambv added OS/Android Fixes related to Android browser functionality bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support labels Jun 16, 2022
@srirambv srirambv added this to Web3 Jun 16, 2022
@srirambv srirambv mentioned this issue Jun 16, 2022
Closed
@deeppandya
Copy link

@srirambv needs to verify on nightly/beta.

@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 24, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 24, 2022
@srirambv
Copy link
Contributor Author

This is currently working on Nightly (1.42.25). @wchen342 mind linking the PR/Commit that fixed this so it can be linked to a milestone?

Repository owner moved this from Backlog to Done in Web3 Jun 27, 2022
@wchen342 wchen342 mentioned this issue Jun 27, 2022
Merged
25 tasks
@wchen342 wchen342 added this to the 1.42.x - Nightly milestone Jun 27, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Jul 1, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.41.86 x64 Beta build

  • Verified able to send ERC721 tokens from account to another.

@kjozwiak kjozwiak mentioned this issue Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srirambv srirambv

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] ERC721 Send brave/brave-core
4 participants
@jamesmudgett @deeppandya @wchen342 @srirambv