Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default wallet setting to "Brave Wallet" causes some webcompat issues #23546

Closed
bbondy opened this issue Jun 17, 2022 · 2 comments · Fixed by brave/brave-core#13854
Closed

Default wallet setting to "Brave Wallet" causes some webcompat issues #23546

bbondy opened this issue Jun 17, 2022 · 2 comments · Fixed by brave/brave-core#13854
Assignees
@bbondy
Labels
feature/web3/wallet/core feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.40.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jun 17, 2022

A regression in 1.39.x is causing the login / connect operation on https://wallet.polygon.technology/ to not work.

The regression causes this issue's work to no longer work when the user's default wallet is "Brave Wallet":
brave/brave-core@819279a

I think it was introduced here:
brave/brave-core@5e085ff#diff-cf0cece38d73d9bb6e7593e045b9c6020641df26897c132feb56a3f10215cfd4R115
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/dapps feature/web3/wallet/core labels Jun 17, 2022
@bbondy bbondy self-assigned this Jun 17, 2022
@bbondy bbondy added this to Web3 Jun 17, 2022
@bbondy bbondy changed the title Default wallet setting to Brave Wallet (not prefer extensions) causes some webcompat issues Default wallet setting to "Brave Wallet" causes some webcompat issues Jun 17, 2022
@bbondy bbondy mentioned this issue Jun 17, 2022
Merged
25 tasks
@bbondy bbondy moved this to Done in Web3 Jun 18, 2022
@bbondy bbondy added this to the 1.42.x - Nightly milestone Jun 18, 2022
@brave-builds brave-builds mentioned this issue Jun 18, 2022
Merged
7 tasks
@bbondy bbondy mentioned this issue Jun 18, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above will require 1.40.105 or higher for 1.40.x verification 👍

@srirambv
Copy link
Contributor

Brave 1.40.105 Chromium: 103.0.5060.53 (Official Build) (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13854
  • Verified able to connect to Dapp when either Brave Wallet (Prefer Extensions) or Brave Wallet is set as default provider
  • Verified able to logout and reconnect to Dapp without issues
23546-Linux.mp4
23546-Windows.mp4
23546-macOS.mov

@bbondy bbondy removed the OS/Android Fixes related to Android browser functionality label Jun 20, 2022
@kjozwiak kjozwiak mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet/core feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.40.x - Release
Development

Successfully merging a pull request may close this issue.

Default wallet setting to "Brave Wallet" causes some webcompat issues brave/brave-core
3 participants
@bbondy @kjozwiak @srirambv