Maker/taker assets in Swap transactions are incorrectly read as ETH

[onyb]

Transaction parser for ETHSwap incorrectly reads maker/taker asset as always ETH. It's reproducible every time the maker/taker assets are not part of visible tokens, even though they are present in the full tokens list.

To reproduce, use matcha.xyz to build a swap transaction and make sure the taker asset is not present in the visible tokens list.

[kjozwiak]

Cleaned up brave/brave-core#18697 as it originally pointed to only #30703 but should have also included this issue as per #30703 (comment). Removed #30703 from labels/milestones as verification will be done with the above issue.

[kjozwiak]

The above requires 1.52.124 or higher for 1.52.x verification 👍

[srirambv]

Verification passed on

Brave	1.52.125 Chromium: 114.0.5735.110 (Official Build) (64-bit)
Revision	1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS	Windows 11 Version 22H2 (Build 22621.1778)

• Verified steps from brave/brave-core#18299
• Verified unknown token show ??? in panel and in activity tab
• Verified clicking on View on block explorer loads the token details page on respective block explorer

23565.mp4