Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eth_signTransaction and eth_sendRawTransaction #23582

Closed
yrliou opened this issue Jun 21, 2022 · 2 comments · Fixed by brave/brave-core#16247
Closed

Support eth_signTransaction and eth_sendRawTransaction #23582

yrliou opened this issue Jun 21, 2022 · 2 comments · Fixed by brave/brave-core#16247

Comments

@yrliou
Copy link
Member

yrliou commented Jun 21, 2022

This issue is to add support of eth_signTransaction provider API, see eth_signTransaction at https://ethereum.github.io/execution-apis/api-documentation/.
Just for reference, https://web3js.readthedocs.io/en/v1.2.11/web3-eth.html#signtransaction for interface defined by web3.js.

Testing app provided by mistx:
https://github.com/juice0x/test-mistx-transaction-app
In this repo there's a test for signing an eth:usdc swap with signTransaction as well as a sample app to test in the browser environment. the code in the test is an example of working code however it will fail due to the mock provider not supporting signTransaction. it should succeed with a provider that supports it.

cc @bbondy

@yrliou yrliou added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/dapps feature/web3/wallet/core labels Jun 21, 2022
@yrliou yrliou added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 21, 2022
@darkdh darkdh assigned darkdh and unassigned supermassive Dec 6, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 8, 2022
@bbondy bbondy changed the title Support eth_signTransaction Support eth_signTransaction and eth_sendRawTransaction Dec 12, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2023

Verification passed on

Brave 1.48.151 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16247
  • Verified signed transaction changes to confirmed when eth_sendRawTransaction goes through
  • Verified one of the signed transaction drops when there are two of them and one of them gets confirmed
  • Encountered #28205
Normal Flow Nonce drop
23582-Normal.Flow.mp4
23582-Nonce.Drop.mp4

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2023

Removing OS/Android label as there is an Android specific issue that is logged #28363

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants