Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing FROM token resets TO token's input amount to zero #23631

Closed
srirambv opened this issue Jun 23, 2022 · 2 comments · Fixed by brave/brave-core#13952
Closed

Changing FROM token resets TO token's input amount to zero #23631

srirambv opened this issue Jun 23, 2022 · 2 comments · Fixed by brave/brave-core#13952
Assignees

Comments

@srirambv
Copy link
Contributor

Description

Changing FROM token resets TO token's input amount to zero

Steps to reproduce

  1. Enter a value for Swap From
  2. Change the Swap To token from BAT to something else
  3. Swap From input value is reset to zero and Swap To value is from previous token

Actual result

1.40.106.mp4

Expected result

Should update the quote value for the new selected token

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.40.106

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky

@kjozwiak
Copy link
Member

The above will require 1.41.88 or higher for 1.41.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Jul 5, 2022

Verification passed on the following devices running 1.41.91 x64 build

  • Verified steps from issue description
  • Verified changing Swap TO token doesn't reset Swap FROM token input value
Oppo Reno 5(Android 12) Samsung Tab A (Android 10)
23631-ARM.mp4
23631-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants