-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Front end work for Brave Translate on Android #23770
Comments
@deeppandya @timchilds Attached are the translate icons, both dark and light, let me know if you need anything else |
@Sam-Sibley can you provide .svg file ? using vector drawables are preferable over pngs |
@deeppandya the SVGs are the second icons in @Sam-Sibley comment. |
@deeppandya These are the png icons for various Android sizes as discussed |
@timchilds i am not if we should include this issue for release note. can you check and update the issue ? |
Verification
|
example | example | example |
---|---|---|
Always translate pages in "(supported language)"
- loaded
bbc.com/mundo
- tapped on the Brave translate ellipsis
- tapped on
Always translate pages in Spanish
- confirmed the page auto-translated to Spanish
- loaded
elpais.com/america
- confirmed it loaded in Spanish then re-rendered in English
- tapped on the ellipsis
- confirmed
Always translate pages in Spanish
was checked
example | example | example | example |
---|---|---|---|
Never translate pages in "(supported language)"
- loaded
mk.ru
- tapped on the Brave translate ellipsis
- tapped on
Never translate pages in Russian
- confirmed the page remained in Russian
- loaded
mail.ru
- confirmed it loaded in Russian
- confirmed there was no
Brave translate
toolbar at the bottom
example | example | example | example | example |
---|---|---|---|---|
Never translate this site
- loaded
jagran.com
- tapped on the Brave translate ellipsis
- tapped on
Never translate this site
- confirmed the page remained in Hindi, and the translation toolbar went away
- loaded
bbc.com/hindi
- confirmed it loaded in Hindi with the Brave translate toolbar visible
example | example | example | example | example | example |
---|---|---|---|---|---|
Page is not in "(supported language)" ?
- loaded
leggo.it
- tapped on the
Brave translate
toolbar's ellipsis - tapped on the
Page is not in Italian?
menu item - chose
Polish
- confirmed the source language in the
Brave translate
toolbar changed toPolish
- confirmed a page translation from Polish to English was attempted (but didn't succeed, as the page isn't in Polish)
example | example | example | example | example |
---|---|---|---|---|
Spec
https://docs.google.com/document/d/1LBmoyUveZaMcnycpRqg91lhzZFjDx_19zM3x6ulNpHg/edit?usp=sharing
The text was updated successfully, but these errors were encountered: