Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DApps: [Android] Browser crashes when adding Harmony network in Wallet and language set to Hindi #23775

Closed
Brave-Matt opened this issue Jun 29, 2022 · 3 comments · Fixed by brave/brave-core#14039
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@Brave-Matt
Copy link

Description

Attempting to add Harmony network (from https://chainlist.org/) in Brave Wallet results in browser crashing.

Steps to reproduce

  1. Go to Chainlist.
  2. Tap on “Connect Wallet”.
  3. Tap on the prompt “This page wants to interact with Brave Wallet”. Notice in the video, that if I didn’t tap on the prompt right away, it doesn’t come back on tapping “Connect Wallet” again. And can be brought back only through Brave Wallet icon in the URL bar.
  4. Login to Brave Wallet
  5. Search Harmony network and “Add to Brave”

Actual result

Browser crashes

Expected result

Harmony added to Brave Wallet

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? N/A
  • Can you reproduce this issue with the current Play Store Nightly version? No

Device details

  • Install type (ARM, x86): x86
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: Android 11

Brave version

1.40.106

Additional information

Initial user report:
https://community.brave.com/t/android-brave-crashes-when-adding-a-network-in-brave-wallet/408504?u=mattches
Video of behavior:
https://drive.google.com/file/d/1F5blGBoG_IagUl-Kcxgzys-YELT1R3ue/view?usp=sharing

@Brave-Matt Brave-Matt added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 29, 2022
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jun 30, 2022
@Pavneet-Sing Pavneet-Sing changed the title [Android] Browser crashes when adding Harmony network in Wallet [Android] Browser crashes when adding Harmony network in Wallet and language set to Hindi Jun 30, 2022
@Pavneet-Sing Pavneet-Sing changed the title [Android] Browser crashes when adding Harmony network in Wallet and language set to Hindi DApps: [Android] Browser crashes when adding Harmony network in Wallet and language set to Hindi Jun 30, 2022
@Pavneet-Sing Pavneet-Sing added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 30, 2022
@qamarngr qamarngr self-assigned this Jun 30, 2022
@qamarngr qamarngr added this to the 1.41.x - Beta milestone Jul 4, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

Changing milestones as this is currently in 1.43.x and hasn't' been uplifted yet. Once uplifted via brave/brave-core#14062 and brave/brave-core#14036, @brave/uplift-approvers will change the milestone as per process.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 8, 2022

The above will require 1.41.95 or higher for 1.41.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on following devices running 1.41.95 x64 build

  • Verified no crash when trying to add a network with language set to Hindi
Oppo Reno 5(Android 12) Samsung Tab A (Android 10)
23775-ARM.mp4
23775-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants