Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is not properly justified with checkbox on onboarding screen #24003

Closed
srirambv opened this issue Jul 12, 2022 · 1 comment · Fixed by brave/brave-core#14142
Closed

Text is not properly justified with checkbox on onboarding screen #24003

srirambv opened this issue Jul 12, 2022 · 1 comment · Fixed by brave/brave-core#14142
Labels
android-tablet-specific bug onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality polish Nice to have — usually related to front-end/visual tasks QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Text is not properly justified with checkbox on onboarding screen

Steps to reproduce

  1. Install 1.41.96 build
  2. Send anonymous diagnostic reports ... text is not justified with the checkbox

Actual result

image

Expected result

Align text properly with the checkbox

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 10

Brave version

1.41.96

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @tapanmodh @deeppandya

@srirambv srirambv added bug polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality android-tablet-specific labels Jul 12, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 12, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 18, 2022

Verified on Samsung Galaxy Tab S7 using

Brave	1.43.74 Chromium: 104.0.5112.102 (Official Build) beta (64-bit) 
Revision	8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS	Android 12; Build/SP1A.210812.016
  • Verified that text is properly justified with checkbox on P3A onboarding screen
Pre 1.43.x (Before) 1.43.x (Fixed)
0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-tablet-specific bug onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality polish Nice to have — usually related to front-end/visual tasks QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants