-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user pref for debouncing feature #24020
Comments
@ShivanKaul is using https://dev-pages.brave.software/navigation-tracking/debouncing.html sufficient for testing the pref on/off setting? cc @brave/qa-team |
Yeah that makes sense. Also apologies, this should be Desktop and Android, I updated the PR but forgot to update the issue. |
Verification
Case 1: Enable
|
step 4-5 | step 6 | step 8 | step 9 |
---|---|---|---|
Case 2: Disable Auto-redirect tracking URLs
- PASSED
- Continue from Case 1:
Auto-redirect tracking URLs
setting inbrave://settings/shields
enabled
- disable
Auto-redirect tracking URLs
setting - visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
- click Run for
Default
condition
Confirmed redirecting didn't work with disabling Auto-redirect tracking URLs
pref
step 2 | step 3 | step 4 | ex | ex |
---|---|---|---|---|
Verification
Case 1: Enable
Confirmed redirecting worked as expected with
Case 2: Disable
Confirmed redirecting didn't work with disabling
|
Verification
Case 1: Enable
|
step 5-6 | step 7 | step 9 | step 10 |
---|---|---|---|
Case 2: Disable Auto-redirect tracking URLs
- PASSED
- Continue from Case 1:
Auto-redirect tracking URLs
setting inbrave://settings/shields
enabled
- disable
Auto-redirect tracking URLs
setting - visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
- click Run for
Default
condition
Confirmed redirecting didn't work with disabling Auto-redirect tracking URLs
pref
step 2 | step 3 | step 4 | ex | ex |
---|---|---|---|---|
Add a new pref to control debouncing to brave://settings/shields. Currently we only have a flag in brave://flags for debouncing.
Setting label:
Auto-redirect tracking URLs
Sublabel:
Enable support for bypassing top-level redirect tracking URLs. Learn More
. Learn more points to https://brave.com/privacy-updates/11-debouncing/Note that De-AMP related debouncing (e.g. debounce AMP cache URLs) would depend on both this new Debounce setting (to debounce at all) and the De-AMP setting prescribed by the
pref
key indebounce.json
, support for which was added in #23121.The text was updated successfully, but these errors were encountered: