Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement declare geo (Phase 1) #24543

Closed
Miyayes opened this issue Aug 9, 2022 · 5 comments · Fixed by brave/brave-core#15430
Closed

[Android] Implement declare geo (Phase 1) #24543

Miyayes opened this issue Aug 9, 2022 · 5 comments · Fixed by brave/brave-core#15430
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 9, 2022

https://github.com/brave/internal/issues/894
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Aug 9, 2022
@Miyayes Miyayes added the QA/Yes label Aug 9, 2022
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 10, 2022
@deeppandya
Copy link

deeppandya commented Aug 12, 2022 •
edited
Loading

@Miyayes possibly a duplicate : #18598 ?

@Miyayes
Copy link
Collaborator Author

Miyayes commented Aug 22, 2022

@Miyayes possibly a duplicate : #18598 ?

This is newer and different. It will actually supersede #18598.

@Miyayes Miyayes mentioned this issue Aug 22, 2022
Closed
@Miyayes Miyayes changed the title [Android] Implement declare geo [Android] Implement declare geo (Phase 1) Aug 26, 2022
@Miyayes Miyayes added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Aug 30, 2022
@deeppandya deeppandya mentioned this issue Oct 17, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 18, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 10, 2022 •
edited
Loading

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.46.99

Verification notes can be found under https://github.com/brave/internal/issues/894#issuecomment-1310572547

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 10, 2022
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 10, 2022
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2022 •
edited
Loading

@deeppandya Could you add test plan for this issue? does Android share the common rewards library for this feature? if so, can we follow the desktop test plan which @zenparsing added in the PR brave/brave-core#15199

cc: @Miyayes @LaurenWags

@deeppandya
Copy link

deeppandya commented Nov 11, 2022 •
edited
Loading

@deeppandya Could you add test plan for this issue? does Android share common rewards lib for this feature? if so, can we follow the desktop test plan which @zenparsing added in the PR brave/brave-core#15199

@GeetaSarvadnya test pan should be the same as @zenparsing 's PR. We just need to verify panel related changes.

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 14, 2022
@kjozwiak kjozwiak mentioned this issue Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Declare geo rewards android brave/brave-core
4 participants
@deeppandya @Miyayes @GeetaSarvadnya @brave-builds