Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Unify responsive Rewards settings page with Android #24570

Closed
Miyayes opened this issue Aug 10, 2022 · 4 comments · Fixed by brave/brave-core#14604
Closed

[Android] Unify responsive Rewards settings page with Android #24570

Miyayes opened this issue Aug 10, 2022 · 4 comments · Fixed by brave/brave-core#14604

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 10, 2022

Description

Use unified responsive Rewards settings page on Android.

Related to #16619.

cc: @deeppandya

@LaurenWags
Copy link
Member

LaurenWags commented Sep 28, 2022

@srirambv @Uni-verse please be sure to see the test plan in brave/brave-core#14604 (comment) and ensure the brave://rewards page is tested thoroughly on Android devices (ARM and Tablet).

As for desktop testing, a single platform is sufficient to do the testing of desktop specific areas listed in brave/brave-core#14604 (comment) cc @GeetaSarvadnya

I'd also suggest doing checks in both portrait and landscape views, particularly for tablet where this will likely cause the display to change.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 29, 2022

Verification PASSED on

Brave | 1.45.78 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 10 Version 21H2 (Build 19044.2006)

Case 1: Drop-down UI controls (updated to use HTML select elements)

Clean profile

Select `Monthly auto-contribution limit`_PASSED
  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm monthly payment drop-down items are listed as expected
  • Confirm that the drop-down items in the Monthly Payment are matching with items in brave://settings/rewards Monthly auto-contribution limit
  • Change the default value and select Up to 5.000BAT in brave://rewards
  • Open brave://rewards and ensure Up to 5.000BAT is retained in AC settings
  • Open brave://rewards in a new tab and ensure Up to 5.000BAT is retained in AC settings
  • Open a new window and ensure Up to 5.000BAT is retained in AC settings
  • Restart the browser and ensure selected value Up to 5.000BAT is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
  • Add few verified sites to AC table and ensure that the selected monthly payment amount is distributed among the pubs.
brave://rewards brave://rewards AC settings brave://settings/rewards AC table Monthly payment distributed
image image image image image
  • Open brave://settings/rewards page and select Monthly auto-contribution limit Up to 7.000BAT
  • Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Select `Minimum page time before logging a visit` _PASSED
  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm Minimum page time before logging a visit drop-down items are listed as expected
  • Open brave://rewards and confirm drop-down items in the Minimum page time before logging a visit are matching with advanced settings on the brave://settings/rewards page
  • Change the default value and select 5 seconds in brave://rewards
  • Open brave://settings/rewards and ensure 5 seconds is retained in AC settings
  • Open brave://rewards in a new tab and ensure 5 seconds is retained in AC settings
  • Open a new window and ensure 5 seconds is retained in AC settings
  • Restart the browser and ensure the selected value 5 seconds is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
  • Ensured that the sites got added to AC table with min page time of 5 seconds
  • Open brave://settings/rewards and change the Minimum page time before logging a visit to 8 seconds, opened brave://rewards and ensured updated value is reflected brave://rewards AC settings page
brave://rewards brave://settings/rewards
image image
Select `Minimum visits for publisher relevancy`_PASSED
  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and confirm Minimum visits for publisher relevancy drop-down items are listed as expected
  • Open brave://rewards and confirm drop-down items in the Minimum visits for publisher relevancy are matching with rewards settings on the brave://settings/rewards
  • Change the default value and select 10 visits in brave://rewards
  • Open brave://rewards and ensure 10 visits is retained in AC settings
  • Open brave://rewards in a new tab and ensure 10 visits is retained in AC settings
  • Open a new window and ensure 10 visits is retained in AC settings
  • Restart the browser and ensure the selected value 10 visits is retained across all the brave://rewards and brave://settings/rewards tabs opened in 1st and 2nd window
  • Ensured that the sites got added to AC table with min visits of 10 visits
  • Open brave://settings/rewards and change the Minimum page time before logging a visit to 5 visits, opened brave://rewards and ensured updated value is reflected brave://rewards AC settings page
brave://rewards brave://settings/rewards
image image

Upgrade profile

Select `Monthly auto-contribution limit`_PASSED
  • Clean profile 1.44.x
  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards page and change the default value for Monthky Payment and select Up to 7.000BAT in AC settings page
  • Open brave://rewards and ensure Up to 7.000BAT is retained in AC settings
  • Upgrade the profile to 1.45.x (renamed the profile to brave beta)
  • Ensured that the selected value Up to 7.000BAT is retained in brave://rewards page
  • Ensured that the selected value Up to 7.000BAT is retained in brave://settings/rewards page
1.44.x 1.44.x 1.45.x 1.45.x
image image image image
  • Open brave://settings/rewards page and select Monthly auto-contribution limit Up to 5.000BAT
  • Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Select `Minimum page time before logging a visit` _PASSED
  • Clean profile 1.44.x
  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards page and change the default value for Minimum page time before logging a visit and select 5 seconds in AC settings page
  • Open brave://settings/rewards and ensure 5 seconds is retained in AC settings
  • Upgrade the profile to 1.45.x (renamed the profile to brave beta)
  • Ensured that the selected value for Minimum page time before logging a visit 5 seconds is retained in brave://rewards page
  • Ensured that the selected value for Minimum page time before logging a visit 5 seconds is retained in brave://settings/rewards page
1.44.x 1.44.x 1.45.x 1.45.x
image image image image
  • Open brave://settings/rewards page and select Minimum page time before logging a visit 8 seconds
  • Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown
Select `Minimum visits for publisher relevancy`_PASSED
  • Clean profile 1.44.x
  • Enable rewards via NTP, claim UGP grants
  • Open brave://rewards and change the default value for Minimum visits for publisher relevancy and select 10 visits in AC settings page
  • Open brave://settings/rewards and ensure 10 visits is retained in AC settings
  • Upgrade the profile to 1.45.x (renamed the profile to brave beta)
  • Ensured that the selected value for Minimum visits for publisher relevancy 10 visits is retained in brave://rewards page
  • Ensured that the selected value for Minimum visits for publisher relevancy 10 visits` is retained in brave://settings/rewards page
1.44.x 1.44.x 1.45.x 1.45.x
image image image image
  • Open brave://settings/rewards page and select Minimum visits for publisher relevancy 5 visits
  • Open brave://rewards and ensured that the updated monthly payment is reflected in the dropdown

Case 2: Sidebar promotions (updated to display in narrow mode)

brave rewads promotions in narrow mode_PASSED

Confirmed promo cards are displayed in the narrow view as expected (mentioned in the test plan)
Confirmed "Manage Brave Rewards" button is not displayed in the narrow view
Confirmed "30-day Ads History" link is not displayed in the narrow view
In narrow view, there is no "View Statement" button (on wallet panel), this matches Android experience and is expected
In narrow view, the nav bar at the top of the brave://rewards page is gone, this also matches the Android experience

Example Example Example Example Example Example
image image image image image image

Case 3: Brave settings toolbar (component ordering was slightly adjusted)

Brave settings toolbar with different window sizes_PASSED
  • Confirmed that Brave settings toolbar looks good with different window sizes
1920 x 1080 880 (px) 1680 x 1050 1440 x 900 1366 x 768 1280 x 1024 1280 x 600
image image image image image image image

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 29, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 19, 2022

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm.aok_1.45.106

  • Verified the test plan from Use responsive Rewards page on Android brave-core#14604 (comment)
  • Confirmed that Rewards AC settings page is same as Desktop
  • Cofirmed that Monthly Payment dropdown is same as Desktop
  • Confirmed that Rewards AC advanced settings page is same as Desktop
  • Confirmed that Min page time before logging a visit dropdown items are same as Desktop
  • Confirmed that Min visits for publisher relevancy dropdown items are same as Desktop
Example Example Example Example Example Example Example Example Example
Screenshot_20221019_133828 Screenshot_20221019_132926 Screenshot_20221019_133837 Screenshot_20221019_133844 Screenshot_20221019_134016 Screenshot_20221019_134040 Screenshot_20221019_134047 Screenshot_20221019_134053 Screenshot_20221019_134826
  • Spot checked the AC and recurring tip and one time tips
  • Confirmed that Rewrads summary in both settings and panel looks good
  • Confirmed that contributions are listed under contributions tab under brave://rewards-internals
Example Example Example Example Example
Screenshot_20221118_145641 Screenshot_20221118_145648 Screenshot_20221118_145750 Screenshot_20221118_145810 Screenshot_20221118_145817

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 19, 2022

Verification PASSED on Android Tab A7 version 12 running Bravemonoarm64.apk_1..45.106

  • Verified the test plan from Use responsive Rewards page on Android brave-core#14604 (comment)
  • Confirmed that Rewards AC settings page is same as Desktop
  • Cofirmed that Monthly Payment dropdown is same as Desktop
  • Confirmed that Rewards AC advanced settings page is same as Desktop
  • Confirmed that Min page time before logging a visit dropdown items are same as Desktop
  • Confirmed that Min visits for publisher relevancy dropdown items are same as Desktop
Example Example Example Example Example Example Example Example Example Example Example Example Example Example
Screenshot_20221020-115826_Brave Screenshot_20221020-115842_Brave Screenshot_20221020-115848_Brave Screenshot_20221020-115905_Brave Screenshot_20221020-115915_Brave Screenshot_20221020-115922_Brave Screenshot_20221020-115931_Brave Screenshot_20221020-115938_Brave Screenshot_20221020-120009_Brave Screenshot_20221020-120039_Brave Screenshot_20221020-121301_Brave Screenshot_20221020-121311_Brave Screenshot_20221020-121332_Brave Screenshot_20221020-121432_Brave
  • Spot checked the AC and recurring tip and one time tips
  • Confirmed that Rewrads summary in both settings and panel looks good
  • Confirmed that contributions are listed under contributions tab under brave://rewards-internals
Example Example Example Example
Screenshot_20221119-121720_Brave Screenshot_20221119-121727_Brave Screenshot_20221119-121803_Brave Screenshot_20221119-121817_Brave

In a clean profile, when we tap on Brave Rewards in 3 dot menu, brave://rewards/ page opens up with Start using Brave Rewards popup modal which is not aligned with Desktop page and this is expected. Confirmed with @zenparsing

Desktop Android
image (9) Screenshot_20221119-124844_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants