Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payout pending message is shown when payout status is "off" at the server side #24705

Closed
GeetaSarvadnya opened this issue Aug 16, 2022 · 1 comment

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #23429
Payout pending message is shown when payout status is "off" at the server side

Steps to Reproduce

Prerequisites: make sure payout status is "off" at the server side

1. Clean install 1.43.x beta build
2. Enable rewards and view an ad
3. Reconcile the ad with server or redeem unblinded payment tokens with server
4. close the browser
5. set the sys clock one day prior to payout date
6. relaunch the browser
7. payout pending message is shown, I was expecting payout pending message banner should not be shown as the configuration at the server side is `unverified`, `bF`, `Gemini`, `Uphold` is set to "off"

Actual result:

Payout pending message is shown when payout status is "off" at the server side

Expected result:

Payout pending message should not be shown when payout status is "off" at the server side

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.71 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Windows 10 Version 21H2 (Build 19044.1889)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @emerick @Miyayes

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Aug 16, 2022

As per the slack thread the payout pending message doesn't consider the endpoint status https://bravesoftware.slack.com/archives/CB0KCRCQN/p1660661295170269?thread_ts=1660030742.289599&cid=CB0KCRCQN, hence it shows the pending or countdown message banner. which is expected as per the thread and spec doc. Only processng and arriived message banners conside the status which is set at the API endpoint, closing the issue as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants