Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add password protection to private key reveal #24830

Closed
yrliou opened this issue Aug 20, 2022 · 3 comments · Fixed by brave/brave-core#14731
Closed

Add password protection to private key reveal #24830

yrliou opened this issue Aug 20, 2022 · 3 comments · Fixed by brave/brave-core#14731
Assignees
@yrliou @SergeyZhukovsky @josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.45.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Aug 20, 2022

We first implemented the protection only in desktop UI side in brave/brave-core#14390.
We still need to

  • Protect GetPrivateKeyForKeyringAccount API with password argument which will be validated in the backend.
  • Update the frontend code in desktop with the API change.
  • Update Android frontend code for UI side password inputs similar to fix: password-protect account private key reveal brave-core#14390 and also update the call of GetPrivateKeyForKeyringAccount to pass password to backend.
    These three items need to be consolidated in one PR.
@yrliou yrliou added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 20, 2022
@yrliou
Copy link
Member Author

yrliou commented Aug 20, 2022

cc @kdenhartog

@yrliou yrliou added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 20, 2022
@yrliou yrliou changed the title Password protect private key reveal Add password protection to private key reveal Aug 20, 2022
@yrliou yrliou mentioned this issue Aug 20, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 26, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.45.88 x64 build

  • Verified steps from brave/brave-core#14731
  • Verified there is a new password prompt when Private Key is selected from Account details view
  • Verified Fingerprint prompt is shown if set
  • Verified private key is only shown when correct password is typed in

Verification passed on Samsung Tab A with Android 10 running 1.45.88 x64 build

  • Verified steps from brave/brave-core#14731
  • Verified there is a new password prompt when Private Key is selected from Account details view
  • Verified Fingerprint prompt is shown if set
  • Verified private key is only shown when correct password is typed in

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from brave/brave-core#14731
  • Verified there is a new password prompt when Private Key is selected from Account details view
  • Verified private key is only shown when correct password is typed in
image image image image

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#14731
  • Verified there is a new password prompt when Private Key is selected from Account details view
  • Verified private key is only shown when correct password is typed in
image image image image

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.6 (Build 21G115)
  • Verified steps from brave/brave-core#14731
  • Verified there is a new password prompt when Private Key is selected from Account details view
  • Verified private key is only shown when correct password is typed in
image image image image

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Oct 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

@SergeyZhukovsky SergeyZhukovsky

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Password-protect private key reveal brave/brave-core
6 participants
@diracdeltas @yrliou @SergeyZhukovsky @srirambv @josheleonard @brave-builds