Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Suppress Mobile “Switch to App” Annoyances #25079

Closed
timchilds opened this issue Aug 30, 2022 · 5 comments · Fixed by brave/brave-core#17024
Closed

[Android] Suppress Mobile “Switch to App” Annoyances #25079

timchilds opened this issue Aug 30, 2022 · 5 comments · Fixed by brave/brave-core#17024
Assignees
@deeppandya @sujitacharya2005
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@timchilds
Copy link

timchilds commented Aug 30, 2022 •
edited
Loading

Spec

https://bravesoftware.slack.com/archives/C03MMJ4CHEZ/p1661878378715489?thread_ts=1661878373.627779&cid=C03MMJ4CHEZ

  1. Apply and enable the "Fanboy's Mobile Notification List" suppression filter lists by default.

  2. Add a toggle to enable/disable. Under settings -> brave shields & privacy -> other privacy settings.

Copy: Block 'Switch to App' Notices
@timchilds
Copy link
Author

@iccub I see this is done for iOS. Could you please confirm which suppression filter list(s) should be enabled/disabled for the "Block 'Switch to App' Notices toggle to function?

@iccub
Copy link

iccub commented Oct 7, 2022

It's this list only

Zrzut ekranu 2022-10-7 o 21 16 10

@timchilds
Copy link
Author

timchilds commented Oct 7, 2022 •
edited
Loading

Thanks @iccub 👍

@deeppandya this ticket should be ready to go. We can use the same copy as iOS for the setting under settings -> brave shields & privacy -> other privacy settings:

image

@deeppandya
Copy link

deeppandya commented Oct 7, 2022 •
edited
Loading

Thank you @iccub @timchilds . I will triage it

@deeppandya deeppandya self-assigned this Oct 12, 2022
@deeppandya deeppandya added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 14, 2022
@sujitacharya2005 sujitacharya2005 mentioned this issue Feb 3, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 21, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 5, 2023 •
edited
Loading

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarmx64.apk_1.50.113

Verified the test plan from brave/brave-core#17024 and gone through the spec https://docs.google.com/document/d/1EWPRDNt3tqxnTjydZXdeiI75Ene0BMEajE4ZHFQCTa8/edit#heading=h.ls63kcwg56s1

  • Confirmed that Block 'Switch to App' Notices switch is added via Brave Shields & privacy settings
  • Confirmed that the switch Block 'Switch to App' Notices is disabled by default
  • Confirmed that when switch is in disabled state Switch to App notices are disaplyed on Twitter, Reddit, Linkedin and Speedtest.net websited
  • Confirmed that when the switch Block 'Switch to App' Notices is enabled, the "Fanboy's Mobile Notification List" suppression filter lists selected by default in brave://adblock
  • Confirmed that when the switch Block 'Switch to App' Notices is enabled state, the Switch to App notices are NOT disaplyed on Twitter, Reddit, Linkedin and Speedtest.net websited

Enable Block 'Switch to App' Notices

Settings enabled brave://adblock Twitter Reddit Linkedin Speedtest.net
Screenshot_20230405_160841 Screenshot_20230405_160902 Screenshot_20230405_160929 Screenshot_20230405_160940 Screenshot_20230405_160951 Screenshot_20230405_161042

Disable Block 'Switch to App' Notices

Settings disabled Twitter Reddit Linkedin Speedtest.net
Screenshot_20230405_155611 Screenshot_20230405_155618 Screenshot_20230405_160155 Screenshot_20230405_155812 Screenshot_20230405_155722

@kjozwiak kjozwiak mentioned this issue Apr 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@sujitacharya2005 sujitacharya2005

Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Suppress Mobile “Switch to App” Annoyances brave/brave-core
6 participants
@deeppandya @iccub @timchilds @sujitacharya2005 @GeetaSarvadnya @brave-builds