Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash report - Brave News #25312

Closed
ghost opened this issue Sep 9, 2022 · 2 comments · Fixed by brave/brave-core#15069
Closed

Crash report - Brave News #25312

ghost opened this issue Sep 9, 2022 · 2 comments · Fixed by brave/brave-core#15069
Assignees
@tapanmodh
Labels
crash feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.43.x - Release #4

Comments

@ghost
Copy link

ghost commented Sep 9, 2022 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#15069

Description ->

When scrolling down the feeds, the browser crashes.

Steps to reproduce

  1. Open the browser (note that this happens if you have Brave News activated)
  2. Scroll down
  3. Crash!

Actual result ->

Screenrecorder-2022-09-09-15-20-51-661.0.mp4

Expected result >

News scrolling correctly.

Issue reproduces how often ->

Everytime

  • Can you reproduce this issue with the current Play Store version? Yes.
  • Can you reproduce this issue with the current Play Store Beta version? Idk
  • Can you reproduce this issue with the current Play Store Nightly version? Idk

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 11 (MIUI 12.5.5)

Brave version -> 1.43.90

Additional information

Another Brave News bug: News settings' banner covers the Privacy Report.

IMG_20220909_153724.jpg
@ghost ghost added the OS/Android Fixes related to Android browser functionality label Sep 9, 2022
@tapanmodh tapanmodh mentioned this issue Sep 12, 2022
Merged
25 tasks
@tapanmodh tapanmodh self-assigned this Sep 12, 2022
@tapanmodh tapanmodh added this to the 1.45.x - Nightly milestone Sep 12, 2022
This was referenced Sep 13, 2022
Merged
Merged
@kjozwiak kjozwiak added crash priority/P2 A bad problem. We might uplift this to the next planned release. feature/brave-news formerly brave-today labels Sep 13, 2022
@kjozwiak
Copy link
Member

The above will require 1.43.93 or higher for 1.43.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.43.93 x64 build

  • Verified steps from issue description
  • Verified scrolling down to the last feed item doesn't crash the browser
25312.mp4

@kjozwiak kjozwiak mentioned this issue Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tapanmodh tapanmodh

Labels
crash feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.43.x - Release #4
Development

Successfully merging a pull request may close this issue.

fix news feed crash on reaching last item in android brave/brave-core
5 participants
@kjozwiak @bsclifton @tapanmodh @srirambv @brave-builds