Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS context menu should be disabled in Private windows #25362

Closed
stephendonner opened this issue Sep 13, 2022 · 2 comments
Closed

IPFS context menu should be disabled in Private windows #25362

stephendonner opened this issue Sep 13, 2022 · 2 comments

Comments

@stephendonner
Copy link

Description

Steps to Reproduce

  1. install 1.45.41
  2. launch Brave
  3. load ipns://docs.ipfs.io
  4. click on Use a Brave local IPFS node
  5. click on the "hamburger menu" -> New Private Window or New Private Window with Tor
  6. load search.brave.com
  7. context-click the page or the brave logo
  8. look at the context menus

Actual result:

IPFS context menu 1 IPFS context menu 2
Screenshot 2022-09-12 at 5 54 57 PM Screenshot 2022-09-12 at 5 55 10 PM

Expected result:

These don't work. We should remove them, I think, because we remove them in the top-level/"hamburger" menu, for these window types.

Of course, if they're supposed to stay, we should fix them.

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @lidel @cypt4 @diracdeltas

@rebron
Copy link
Collaborator

rebron commented Sep 23, 2022

cc: @spylogsster

@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants