Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Brave Ads subdivision targeting fetch business logic #25676

Closed
aseren opened this issue Sep 28, 2022 · 1 comment · Fixed by brave/brave-core#18522
Closed

Refactor Brave Ads subdivision targeting fetch business logic #25676

aseren opened this issue Sep 28, 2022 · 1 comment · Fixed by brave/brave-core#18522
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@aseren
Copy link

aseren commented Sep 28, 2022

No description provided.

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jan 31, 2023
@tmancey tmancey self-assigned this Jan 31, 2023
@tmancey tmancey added dev-concern and removed enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jan 31, 2023
@tmancey tmancey removed their assignment Apr 13, 2023
@tmancey tmancey changed the title Revise subdivision targeting fetch logic Refactor Brave Ads subdivision targeting fetch business logic Apr 13, 2023
@tmancey tmancey self-assigned this May 15, 2023
@tmancey tmancey added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels May 15, 2023
@tmancey tmancey mentioned this issue May 17, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 19, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.53.99 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#18522

Verified subdivision targeting is fetched:

[8154:8154:0620/103907.300837:VERBOSE1:subdivision_targeting.cc(237)] OnFetchSubdivisionTargeting
[8154:8154:0620/103907.301566:VERBOSE6:subdivision_targeting.cc(239)] URL Response:
  URL: https://geo.ads.bravesoftware.com/v1/getstate
  Response Status Code: 200
  Response: {"country":"US","region":"NY"}

Verified subtargeting works:
image

Verified subtargeted ad was shown

[8154:8154:0620/104515.681652:VERBOSE1:eligible_notification_ads_v2.cc(38)] Get eligible notification ads
[8154:8154:0620/104515.689072:VERBOSE1:eligible_notification_ads_v2.cc(124)] 1 eligible ads out of 1 ads
[8154:8154:0620/104515.689664:VERBOSE1:notification_ad_handler.cc(121)] Opportunity arose to serve a notification ad
[8154:8154:0620/104515.690046:VERBOSE1:notification_ad_serving.cc(127)] Found 1 eligible ads
[8154:8154:0620/104515.690411:VERBOSE1:notification_ad_serving.cc(200)] Served notification ad:
  placementId: 19a30a3f-260f-45e8-8bb9-fe6ca4b183a1
  creativeInstanceId: 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed
  creativeSetId: 5f8c4787-8431-49a5-9d09-bba40f8ad5f4
  campaignId: d1e25388-b362-4f30-bd4b-36b8205e59e5
  advertiserId: a34de75d-5654-4331-8713-8f4d4e2b6bf7
  segment: untargeted
  title: subtargeting - new york
  body: subtargeting - new york
  targetUrl: https://www.apple.com/

Verified notification ad was shown

[5365:5365:0620/101432.236551:VERBOSE1:eligible_notification_ads_v2.cc(38)] Get eligible notification ads
[5365:5365:0620/101432.243446:VERBOSE2:exclusion_rules_base.cc(120)] creativeSetId 45ea5952-37ca-41f0-88c2-4b546b0e6f4b has exceeded the perDay frequency cap
[5365:5365:0620/101432.269323:VERBOSE1:eligible_notification_ads_v2.cc(124)] 10 eligible ads out of 20 ads
[5365:5365:0620/101432.269547:VERBOSE1:notification_ad_handler.cc(121)] Opportunity arose to serve a notification ad
[5365:5365:0620/101432.269761:VERBOSE1:notification_ad_serving.cc(127)] Found 1 eligible ads
[5365:5365:0620/101432.269832:VERBOSE1:notification_ad_serving.cc(200)] Served notification ad:
  placementId: e5419dd6-601c-49e4-9518-02cda2cc17e2
  creativeInstanceId: 238c11b6-c194-4d10-879f-7e4cd7a6ccb5
  creativeSetId: c5869bfb-7b3e-45e9-83c8-66ec3ac2b937
  campaignId: 12e88c0d-fb1b-4316-ade0-cc06eb57227e
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Dell US DOM
  body: Dell US DOM
  targetUrl: https://info.kore.ai/platform-freetrial-dev?utm_campaign=PLG-AD-BuySellAds-Platform&utm_source=buysellads&utm_medium=bsa-brave-push-test
[5365:5365:0620/101432.271738:VERBOSE6:ads_service_impl.cc(820)] Timeout notification ad with placement id e5419dd6-601c-49e4-9518-02cda2cc17e2 in 120 s
[5365:5365:0620/101432.271808:VERBOSE3:notification_ad_event_served.cc(19)] Served notification ad with placement id e5419dd6-601c-49e4-9518-02cda2cc17e2 and creative instance id 238c11b6-c194-4d10-879f-7e4cd7a6ccb5
[5365:5365:0620/101432.272516:VERBOSE9:client_state_manager.cc(492)] Saving client state
[5365:5365:0620/101432.273512:VERBOSE3:notification_ad_event_viewed.cc(19)] Viewed notification ad with placement id e5419dd6-601c-49e4-9518-02cda2cc17e2 and creative instance id 238c11b6-c194-4d10-879f-7e4cd7a6ccb5
[5365:5365:0620/101432.274696:VERBOSE9:client_state_manager.cc(492)] Saving client state
[5365:5365:0620/101432.305636:VERBOSE1:notification_ad_event_served.cc(27)] Successfully logged notification ad served event
[5365:5365:0620/101432.318417:VERBOSE9:client_state_manager.cc(506)] Successfully saved client state
[5365:5365:0620/101432.328354:VERBOSE6:notification_ad_event_viewed.cc(27)] Successfully logged notification ad viewed event

Verified ntp si was served

[5365:5365:0620/100346.899485:VERBOSE1:eligible_new_tab_page_ads_v2.cc(37)] Get eligible new tab page ads
[5365:5365:0620/100346.909890:VERBOSE2:tab_manager.cc(212)] Tab id 578175675 did change
[5365:5365:0620/100346.914548:VERBOSE6:user_activity_manager.cc(42)] Triggered event: 11 (0:0:900 s)
[5365:5365:0620/100346.954550:VERBOSE1:eligible_new_tab_page_ads_v2.cc(124)] 4 eligible ads out of 4 ads
[5365:5365:0620/100346.963238:VERBOSE1:new_tab_page_ad_handler.cc(56)] Opportunity arose to serve a new tab page ad
[5365:5365:0620/100346.963572:VERBOSE1:new_tab_page_ad_serving.cc(91)] Found 1 eligible ads
[5365:5365:0620/100346.963653:VERBOSE1:new_tab_page_ad_serving.cc(122)] Served new tab page ad:
  placementId: d6165d58-aac3-4ed8-b04a-3935d0092779
  creativeInstanceId: 8ea7efdf-00cb-4c66-981d-31216b82b2f8
  creativeSetId: 46cf9cc5-4932-4440-9aca-96ce04c73aa2
  campaignId: 0c281843-7d8b-40f1-9bb9-91d4e74ff5a4
  advertiserId: 803953a8-56b4-4d4b-942a-fa81357f1427
  segment: untargeted
  companyName: BMW
  imageUrl: https://mobile-data-dev.s3.brave.software/assets/ntp-si/69aa9044-d6d2-4e24-ac03-958391b2bb7a.png
  alt: BMW
  targetUrl: https://www.bmwusa.com/?brave-creative-id=%%CREATIVE_INSTANCE%%&source=image2
  wallpaper:
    imageUrl: https://mobile-data-dev.s3.brave.software/assets/ntp-si/736cec25-e7d7-4b20-9c7c-fbd0c1c99325.jpg
    focalPoint:
      x: 1091
      y: 720
[5365:5365:0620/100346.975969:VERBOSE3:new_tab_page_ad_event_served.cc(19)] Served new tab page ad with placement id d6165d58-aac3-4ed8-b04a-3935d0092779 and creative instance id 8ea7efdf-00cb-4c66-981d-31216b82b2f8
[5365:5365:0620/100346.980677:VERBOSE9:client_state_manager.cc(492)] Saving client state
[5365:5365:0620/100346.995525:VERBOSE6:new_tab_page_ad_event_served.cc(27)] Successfully logged new tab page ad served event

Verified Brave news inline ad was shown

[5365:5365:0620/100553.205985:VERBOSE1:eligible_inline_content_ads_v2.cc(39)] Get eligible inline content ads
[5365:5365:0620/100553.227159:VERBOSE1:eligible_inline_content_ads_v2.cc(129)] 2 eligible ads out of 2 ads
[5365:5365:0620/100553.227995:VERBOSE1:inline_content_ad_handler.cc(59)] Opportunity arose to serve an inline content ad
[5365:5365:0620/100553.228700:VERBOSE1:inline_content_ad_serving.cc(96)] Found 1 eligible ads
[5365:5365:0620/100553.229601:VERBOSE1:inline_content_ad_serving.cc(125)] Served inline content ad:
  placementId: 5ee4d0f4-3c33-4554-8f1b-8dda662d344a
  creativeInstanceId: e4958d00-e35c-4134-a408-1fbcf274d5ae
  creativeSetId: 8b848823-c47f-43de-a753-2efa8dea6863
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Staging - Inline Test 1
  description: Fung Brave News Inline Display Ad - mac/linux
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: Work at Brave
  targetUrl: https://brave.com/careers
[5365:5365:0620/100553.334391:VERBOSE3:inline_content_ad_event_served.cc(19)] Served inline content ad with placement id 5ee4d0f4-3c33-4554-8f1b-8dda662d344a and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[5365:5365:0620/100553.336137:VERBOSE9:client_state_manager.cc(492)] Saving client state
[5365:5365:0620/100553.372802:VERBOSE1:inline_content_ad_event_served.cc(27)] Successfully logged inline content ad served event

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor Brave Ads subdivision targeting fetch business logic brave/brave-core
4 participants
@tmancey @btlechowski @brave-builds @aseren