Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use host name for default sync device name #2573

Closed
darkdh opened this issue Dec 14, 2018 · 1 comment · Fixed by brave/brave-core#1136
Closed

Use host name for default sync device name #2573

darkdh opened this issue Dec 14, 2018 · 1 comment · Fixed by brave/brave-core#1136
Assignees
@darkdh
Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@darkdh
Copy link
Member

darkdh commented Dec 14, 2018

Instead of displaying Mac/Linux/Windows Desktop, we should use these API to get hostname info

http://man7.org/linux/man-pages/man2/gethostname.2.html
https://docs.microsoft.com/en-us/windows/desktop/api/winsock/nf-winsock-gethostname
@darkdh darkdh self-assigned this Dec 14, 2018
@darkdh darkdh mentioned this issue Dec 14, 2018
Closed
@darkdh darkdh mentioned this issue Dec 19, 2018
Merged
18 tasks
@darkdh darkdh added the QA/Yes label Dec 19, 2018
@darkdh darkdh added this to the 0.60.x - Dev milestone Dec 19, 2018
@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux
  • New sync chain adds device name automatically

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10
  • New sync chain adds device name automatically

image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Verified host name is used by default

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use gethostname to setup default device name brave/brave-core
6 participants
@bbondy @cezaraugusto @darkdh @srirambv @LaurenWags @GeetaSarvadnya