[BRAVE WALLET] Can't delete/hide certain networks

[Pandapip1]

Description

When I try to delete any of the following networks, the "Remove" item does not appear:

• Ethereum Mainnet
• Polygon Mainnet
• Binance Smart Chain Mainnet
• Celo Mainnet
• Avalanche C-Chain
• Fantom Opera
• Optimism
• Aurora Mainnet
• Rinkeby Test Network
• Ropsten Test Network
• Goerli Test Network
• Kovan Test Network
• Localhost

Other networks can be interacted with as usual.

Steps to Reproduce

1. Open brave://settings/wallet/networks
2. Click on the three dots by one of the above networks
3. The "Remove" item does not appear

Actual result:

Expected result:

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave	1.44.105 Chromium: 106.0.5249.91 (Official Build) (64-bit)
Revision	fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS	Windows 11 Version 21H2 (Build 22000.978)

Version/Channel Information:

• Can you reproduce this issue with the current release? YES
• Can you reproduce this issue with the beta channel? (NOT TESTED)
• Can you reproduce this issue with the nightly channel? (NOT TESTED)

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NO
• Does the issue resolve itself when disabling Brave Rewards? NO
• Is the issue reproducible on the latest version of Chrome? (NOT APPLICABLE)

Miscellaneous Information:

N.A.

[srirambv]

Those are pre-loaded networks and can't be removed. Any reason why it needs to be removed?

[Pandapip1]

Any reason why it needs to be removed?

They take up a lot of space on the network management page. All I need is the Ethereum mainnet and testnets (and I'll eventually add zk-EVMs when they are released). How hard would this feature be to add?

[bbondy]

If we add a way to remove these, we'd also need a way to restore them. Since this is a deep buried settings screen, I was just wondering why it's important to remove them vs hide them with the eye icon?

[Pandapip1]

we'd also need a way to restore them

What's wrong with wallet_addEthereumChain? Almost all DApps are configured to automatically add and switch to the app's native chain if needbe.

[bbondy]

if someone wants to restore it back to how it was before they'd need to know our RPC URLs or know how to go to a page that we'd setup that has links to do so. Note the list there is simply a config and it is not something actively running that's using up resources.

[Pandapip1]

I know. It's still really annoying to have 8 networks that I don't use clogging up the network switcher & config (as someone who also doesn't trust the security of sidechains, I am also concerned that a security-focused browser is proving easy access to these less secure defaults).

If you want, create a page to re-add the networks. But I doubt anyone is going to delete the networks by mistake or not know how to re-add them using something like https://chainlist.org/

[bbondy]

The network switcher is within the wallet and within the panel btw. This is just settings for config of the networks. But point taken.

or not know how to re-add them using something like https://chainlist.org/

chainlist.org usually has public node RPCs. We have built-in RPC endpoints which are not rate limited and have better up time. Proxied to drop IP for requests to Infura (or possibly a different provider in the future)

[Pandapip1]

We have built-in RPC endpoints which are not rate limited and have better up time.

Is it okay for me to add these to chainlist? I would also be okay with brave automatically adding its own RPCs for matching networks (and adding a tickbox to disable this functionality).

[bbondy]

No. These are for Brave users only.

[Pandapip1]

I would also be okay with brave automatically adding its own RPCs for matching networks (and adding a tickbox to disable this functionality).

How about this then? E.G. if I add a network with chain ID 137, it automatically populates the Brave RPC?

[Pandapip1]

How about this instead: on the networks list, when you hide the network, it doesn't appear in the switcher. It can still be switched to with the wallet_switchethereumchain RPC, but it just doesn't appear in the network list:

In this instance, celo, avalanche, fantom, and aurora would be hidden from the network selector. Just a reminder, this is the network selector I'm talking about: