Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up issue to # 15048 - Server -side cookie expiration limit shows 2 days instead of 6 months #25787

Closed
MadhaviSeelam opened this issue Oct 3, 2022 · 4 comments

Comments

@MadhaviSeelam
Copy link

Description

Steps to Reproduce

  1. Install 1.45.84
  2. launch Brave
  3. visited https://fmarier.org/document-cookie/set-cookie4.html
  4. Opened the Application tab in the devtools.
  5. Clicked on Storage, then Cookies in the sidebar.
  6. Clicked on https://fmarier.org and looked at the expiry column.
  7. Opened brave://settings/cookies/detail?site=fmarier.org and checked the expiry date

Actual result:

expiry date shows Oct 5, 2022 (2022-10-05T22:04:30.414Z) instead of 6 months (i.e. April 01, 2023)

ex1 ex2
image image

Expected result:

Should expire 6 months from the current date (i.e. 2023-04-01T22:09:13.740Z)

Reproduces how often:

image

Brave version (brave://version info)

Brave 1.45.84 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
Revision fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS Windows 11 Version 21H2 (Build 22000.978)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@ShivanKaul @rebron

cc: @stephendonner

@MadhaviSeelam MadhaviSeelam changed the title Server -side cookie expiration limit shows 2 days instead of 6 months Follow up issue to # 15048 - Server -side cookie expiration limit shows 2 days instead of 6 months Oct 3, 2022
@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Oct 4, 2022

@MadhaviSeelam the issue here is that the cookie expires in 2 days, right? I see that for https://fmarier.org/document-cookie/set-cookie4.html the server sends back header set-cookie: test4=yes; max-age=172800 which is 2 days. Looks like the test plan in brave/brave-core#1905 (comment) is incorrect, and should say that for set-cookie4.html the expected days is 2 days, and not 6 months. I see that #3443 (comment) also verified that set-cookie4.html sets cookie for 2 days. I'll update the test plan (done).

TL;DR: The test plan was incorrect. Let me know how that sounds!

@MadhaviSeelam
Copy link
Author

@ShivanKaul sounds good to me. Will close this issue in that case.

@ShivanKaul ShivanKaul self-assigned this Oct 4, 2022
@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Oct 4, 2022

Closing the issue as the testplan was amended for the correct expiration date and as per above comment for the scenario.

@cemerson
Copy link

My apologies if I should post this as a new issue but it seems related (?). I'm setting a cookie to expire in 30 days but Brave (and Opera) show an expiration date of 7 days from now vs 30 (?). Is this just a visual bug or is the cookie actually setting the wrong date in Brave too?

browser-cookie-expdate-bugs-20230317064240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants