Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typing chrome://sync autocompletes to chrome://sync-internals #2603

Closed
cezaraugusto opened this issue Dec 17, 2018 · 1 comment · Fixed by brave/brave-core#1341
Closed

typing chrome://sync autocompletes to chrome://sync-internals #2603

cezaraugusto opened this issue Dec 17, 2018 · 1 comment · Fixed by brave/brave-core#1341
Labels
feature/autocomplete priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.61.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Dec 17, 2018 •
edited by bbondy
Loading

Test Plan:

  1. Type chrome://sync
  2. Autocompletes to chrome://sync-internals

chrome://sync is much more mainstream than chrome://sync-internals and should not autocomplete

cc @darkdh
@bbondy bbondy added this to the 1.x Backlog milestone Dec 22, 2018
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 14, 2019
@bbondy bbondy changed the title typing brave://sync autocompletes to brave://sync-internals typing chrome://sync autocompletes to chrome://sync-internals Jan 14, 2019
@bbondy bbondy added the QA/Yes label Jan 14, 2019
This was referenced Jan 14, 2019
Merged
Merged
Merged
@bbondy bbondy modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 14, 2019
@btlechowski
Copy link

btlechowski commented Feb 26, 2019 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from the description

2603

Verification passed on

Brave 0.61.41 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint
  • Verified the description mentioned in the issue.

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X
  • Verified STR from description

This was referenced Mar 1, 2019
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/autocomplete priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.61.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Autocomplete to chrome://sync and not chrome://sync-internals brave/brave-core
6 participants
@bbondy @cezaraugusto @rebron @LaurenWags @btlechowski @GeetaSarvadnya