Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Geo declaration causes app to crash (1.46.x) #26286

Closed
Miyayes opened this issue Oct 26, 2022 · 2 comments · Fixed by brave/brave-core#16341
Closed

[Android] Geo declaration causes app to crash (1.46.x) #26286

Miyayes opened this issue Oct 26, 2022 · 2 comments · Fixed by brave/brave-core#16341
Assignees
Labels
bug crash feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 26, 2022

Description

From user report:

image

cc: @anthonypkeane

@Miyayes Miyayes added bug crash feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Android Fixes related to Android browser functionality labels Oct 26, 2022
@Miyayes Miyayes added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Nov 30, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 6, 2022
@Miyayes Miyayes added the QA/No label Dec 6, 2022
@Miyayes Miyayes reopened this Dec 9, 2022
@Miyayes Miyayes added QA/Yes and removed QA/No needs-more-info The report requires more detail before we can decide what to do with this issue. labels Dec 12, 2022
@kjozwiak
Copy link
Member

The above requires 1.46.143 or higher for 1.46.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Dec 13, 2022

Verified on Samsung J7 Neo with Android 7 running 1.46.143.

Follow up issue logged: #27336

  • Verified the test plan from [Android] fix crash brave rewards onboarding country selection brave-core#16341 (comment).
  • Reproduced the issue using device above and version 1.46.138.
  • Verified that when using 1.46.143, the browser did not crash when tapping on the list of countries from the rewards panel. Confirmed able to select my country (US), and join Rewards. Was presented with onboarding tour and "first ad" as expected.
  • Confirmed this worked for clean profile without issue.
  • For upgrades, one upgrade case worked, the other did not.
Upgrade Case 1 - FAILED, follow up issue logged
  1. Install 1.46.138
  2. Reproduce crash
  3. Upgrade to 1.46.143
  4. Tap on rewards icon
    --> no country selection/onboarding. Panel looks odd. brave://rewards-internals shows "no wallet created". Appears as though rewards is in some kind of borked state. Close/reopen panel, close/reopen app - none of this resolves the issue and brings up country selection/onboarding.
Example Example
Screenshot_20221213-084250 Screenshot_20221213-084311
Upgrade Case 2 - PASSED
  1. Install 1.45.133 (last version before country selection)
  2. Enable rewards
  3. Confirm brave://rewards-internals shows wallet info
  4. Upgrade to 1.46.138
  5. Reproduce crash
  6. Upgrade to 1.46.143
  7. Tap on rewards icon
  8. Get country selection, able to select country, confirmed ad earning balance was retained.
1.45.133 1.46.143 1.46.143
Screenshot_20221213-084835 Screenshot_20221213-085756 Screenshot_20221213-085808
1.46.138 1.46.143
138 143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants