Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading Signing Request Message (BRA-Q322-7) #26372

Closed
SergeyZhukovsky opened this issue Oct 28, 2022 · 2 comments · Fixed by brave/brave-core#15806
Closed

Misleading Signing Request Message (BRA-Q322-7) #26372

SergeyZhukovsky opened this issue Oct 28, 2022 · 2 comments · Fixed by brave/brave-core#15806
Assignees
@SergeyZhukovsky
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include security
Milestone
1.45.x - Release #7

Comments

@SergeyZhukovsky
Copy link
Member

Basically implement of what we have on desktop #24816
@SergeyZhukovsky SergeyZhukovsky added security priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Oct 28, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 3, 2022
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Nov 4, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 5, 2022
This was referenced Nov 7, 2022
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Nov 7, 2022

The above requires 1.46.97 or higher for 1.46.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.45.125 x64 build

  • Verified steps from #24816
  • Verified when non-ASCII code is passed in Sign transaction, a warning message is show
  • Verified clicking on View message in ASCII encoding shows the ASCII code in message
  • Verified clicking on View original message shows the encoded message
  • Logged followup issue #26692
Samsung Tab A(Android 10) Oppo Reno 5 (Android 12)
26372-Tab.mp4
26372-ARM.mp4

This was referenced Nov 15, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.45.x - Release #7
Development

Successfully merging a pull request may close this issue.

Adds extra validations on a wallet sign message screen on Android brave/brave-core
4 participants
@kjozwiak @SergeyZhukovsky @srirambv @brave-builds