Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash from Google Play Console inside RetentionNotificationPublisher #26444

Closed
SergeyZhukovsky opened this issue Nov 1, 2022 · 0 comments · Fixed by brave/brave-core#15746
Closed
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@SergeyZhukovsky
Copy link
Member

Exception java.lang.RuntimeException: Unable to start receiver org.chromium.chrome.browser.notifications.retention.RetentionNotificationPublisher: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.pm.PackageManager android.content.Context.getPackageManager()' on a null object reference
  at android.app.ActivityThread.handleReceiver (ActivityThread.java:4345)
  at android.app.ActivityThread.access$1700 (ActivityThread.java:286)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2153)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loop (Looper.java:254)
  at android.app.ActivityThread.main (ActivityThread.java:8219)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:612)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1006)
Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.pm.PackageManager android.content.Context.getPackageManager()' on a null object reference
  at org.chromium.chrome.browser.download.home.list.holder.CardDividerTopViewHolder.b (CardDividerTopViewHolder.java:14)
  at org.chromium.chrome.browser.notifications.retention.RetentionNotificationPublisher.onReceive (RetentionNotificationPublisher.java:139)
  at android.app.ActivityThread.handleReceiver (ActivityThread.java:4329)

I wasn't able to replicate it, but it looks like it cannot execute a retention notification for some reason. It's good to just catch a NullPointerException to prevent a whole browser crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants