Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Web Discovery Project promo to use infobar instead of dialog #26576

Closed
simonhong opened this issue Nov 6, 2022 · 4 comments · Fixed by brave/brave-core#15822
Closed

Update Web Discovery Project promo to use infobar instead of dialog #26576

simonhong opened this issue Nov 6, 2022 · 4 comments · Fixed by brave/brave-core#15822
Assignees
@simonhong
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.47.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Nov 6, 2022 •
edited by bsclifton
Loading

Replace WDP promotion dialog with infobar

  • Show Infobar on Brave Search result page
  • User can see 5 times maximum and only once per day if not dismissed
  • If dismissed, it'll not be shown for current call to action (CTA)
  • Infobar state is tied with specific CTA
    • This means infobar can be visible again with new CTA
      - Design and sentences are not finalized yet
@simonhong simonhong self-assigned this Nov 6, 2022
@simonhong simonhong mentioned this issue Nov 7, 2022
Merged
25 tasks
@simonhong simonhong added QA/Yes and removed QA/No labels Nov 7, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 11, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Nov 23, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 6, 2022 •
edited
Loading

Verification PASSED using

Brave | 1.47.115 Chromium: 108.0.5359.94 (Official Build) beta (64-bit)
-- | --
Revision | 713576b895246504ccc6b92c2fb8ce2d60194074-refs/branch-heads/5359_71@{#3}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Steps:

  1. Install 1.47.115
  2. launch brave
  3. Skip on-boarding modal

Case 1: WDP infobar UI - PASSED

  1. open brave://settings/search
  2. select Google as a non-Brave Search as a default search engine for Normal Window entry
  3. visit https://search.brave.com/search?q=Brave&source=web
  4. confirmed WDP infobar is not shown
  5. visit brave://settings/?search=web+discovery and enable Web Discovery Project
  6. set Brave as a default search engine
  7. reload https://search.brave.com/search?q=Brave&source=web
  8. confirmed WDP infobar is not shown
  9. disable WDP via brave://settings/?search=web+discovery
  10. reload https://search.brave.com/search?q=Brave&source=web)
  11. confirmed WDP infobar is shown with text Help improve Brave Search by sending anonymouse usage data
step 2 step3-4 step 5-6 step7-8 step9-10 step 11
image image image image image image
Dark mode Light mode Wide layout with narrow horizontal padding Narrow layout
image image image image

Case 2: Opt-in to WDP - PASSED

  1. continue from Case 1
    WDP infobar is shown with text Help improve Brave Search by sending anonymouse usage data
  2. click OK button
  3. confirmed infobar dismissed
  4. confirmed Web Discovery Project is enabled
step 1-2 step 3 step 4
image image image

Case 3: Dismiss (x) the infobar - PASSED

  1. new profile
  2. open brave://settings/search
  3. select Google as a non-Brave Search as a default search engine for Normal Window entry
  4. set Brave as a default search engine
  5. visit https://search.brave.com/
  6. confirmed WDP infobar is shown with text Help improve Brave Search by sending anonymouse usage data
  7. click x to dismiss the infobar
  8. confirmed WDP infobar is hidden
step 2-3 step 4 step 6 step 8
image image image image

Case 4: Show Infobar again once dismissed - PASSED

Pre-req: Dismiss (x) the Infobar from Case 3

  1. Close Brave
  2. Open Preferences file in the profile folder
  3. navigate to following and delete the last digit to simulate a day passed
    • web_discovery":{"cta_state":{"count":1,"dismissed":false,"id":"v1","last_displayed":"13314922424094719
  4. changed the last digit - from 9 to 1
  5. relaunch Brave

Confirmed InfoBar is shown

pre-req step 3 step 4 result
image image image image

Case 5: Dismiss the Infobar (No thanks) - PASSED

  1. New profile
  2. launch brave
  3. open brave://settings/search
  4. select Google as a non-Brave Search as a default search engine for Normal Window entry
  5. return to brave://settings/search and set Brave as a default search engine
  6. visit https://search.brave.com
  7. click No thanks on the Infobar
  8. close and relaunch Brave
  9. reload https://search.brave.com

Confirmed InfoBar is NOT shown

step 7 result
image image

Case 6: InfoBar is shown once per day if it's not dismissed - PASSED

  1. New profile
  2. launch brave
  3. open brave://settings/search
  4. select Google as a non-Brave Search as a default search engine for Normal Window entry
  5. return to brave://settings/search and set Brave` as a default search engine
  6. visit https://search.brave.com/search?q=Brave&source=web
  7. confirmed the WDP infobar displayed
  8. do not click x to dismiss the Infobar
  9. close Brave
  10. advance system date by 1 day ( Windows-->Settings-->Time & Language-->Date & Time (Dec 7))
  11. refresh the page https://search.brave.com/search?q=Brave&source=web

Confirmed InfoBar is shown

step 7 step10 result
image image image

Case 7: Edit CTA id in the preferences file once Infobar is dismissed - PASSED

  1. continue Case 5:
  2. close Brave
  3. open Preferences file in the profile folder
  4. navigate to following and delete the last digit to simulate a day passed
    • web_discovery":{"cta_state":{"count":1,"dismissed":false,"id":"v1","last_displayed":"13314829675178426
  5. changed the id - fom v1 to g1
  6. relaunch Brave
  7. reload search.brave.com

Confirmed Infobar is shown

step 4 step 5 result
image image image

Case 8: InfoBar is shown 5 times at most for a profile if the infobar is not dismissed - PASSED

  1. New profile
  2. launch brave
  3. open brave://settings/search in new-tab
  4. select Google as a non-Brave Search as a default search engine for Normal Window entry
  5. switch to Brave as a default search engine in `brave://settings/search
  6. visit https://search.brave.com and WDP infobar is shown
  7. open Preferences file and navigate to following and confirm "count": 1
    • web_discovery":{"cta_state":{"count":1,"dismissed":false,"id":"v1","last_displayed":"13314992203567416
  8. close Brave
  9. advance system date by 1 day ( Windows-->Settings-->Time & Language-->Date & Time (Dec 8-Dec 9))
  10. relaunch Brave and confirmed the infobar is shown on search.brave.com page
  11. navigate to following and confirm count increased by 1
    • web_discovery":{"cta_state":{"count":2,"dismissed":false,"id":"v1","last_displayed":"13315078925875786"
  12. confirmed "count": 2
  13. repeat step 9 - 11 till 3 more times till the "count": 5
  14. repeat steps 9-11 for Day 6/Run 6
  15. relaunch Brave

confirmed the infobar is not shown on search.brave.com page

open Preferences file and confirmed the count remained 5 in "count": 5

step 4 step 5 step 6 step 7
image image image image

Day 2 - count 2

step 9 step 10 step 12
image image image

Day 3 - count 3

Ex1 Ex2 Ex3
image image image

Day 4 - count 4

Ex1 Ex2 Ex3
image image image

Day 5 - count 5

Ex1 Ex2 Ex3
image image image

Day 6 - count 6

ex1 ex2 ex3
image image image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 6, 2022
@bsclifton bsclifton changed the title Use infobar for WDP promotion instead of dialog Update Web Discovery Project promo to use infobar instead of dialog Dec 6, 2022
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 labels Dec 8, 2022
@MadhaviSeelam
Copy link

Testing is complete however, as per @rebron this may be QA/No to let Brave Search team take a look.
cc: @kjozwiak @LaurenWags

@stephendonner
Copy link

Testing is complete however, as per @rebron this may be QA/No to let Brave Search team take a look. cc: @kjozwiak @LaurenWags

Got the OK to keep going from @rebron 👌

@stephendonner
Copy link

stephendonner commented Dec 12, 2022 •
edited by btlechowski
Loading

Verification PASSED using

Brave 1.47.125 Chromium: 108.0.5359.99 (Official Build) beta (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 11.7.1 (Build 20G918)

Case 1: WDP infobar UI - PASSED

  1. opened brave://settings/search
  2. selected Google as the non-Brave Search default engine or Normal Window entry
  3. visited https://search.brave.com/?q=Brave&source=web
  4. confirmed WDP infobar wasn't shown
  5. enabled Web Discovery Project via brave://settings/?search=web+discovery
  6. set Brave as the default search engine for Normal Window
  7. reloaded https://search.brave.com/?q=Brave&source=web
  8. confirmed WDP infobar wasn't shown
  9. disabled WDP via brave://settings/?search=web+discovery
  10. reloaded https://search.brave.com/?q=Brave&source=web
  11. confirmed WDP infobar is shown with text Help improve Brave Search by sending anonymous usage data
step 2 steps 3-4 steps 5-6 steps 7-8 steps 9-10 step 11
Screen Shot 2022-12-12 at 12 22 42 PM Screen Shot 2022-12-12 at 12 23 12 PM Screen Shot 2022-12-12 at 12 23 52 PM Screen Shot 2022-12-12 at 12 24 57 PM Screen Shot 2022-12-12 at 12 25 08 PM Screen Shot 2022-12-12 at 12 25 14 PM
Dark mode Wide Smallest window constraint
Screen Shot 2022-12-12 at 12 34 57 PM Screen Shot 2022-12-12 at 12 35 32 PM Screen Shot 2022-12-12 at 12 35 23 PM

Case 2: Opt-in to WDP - PASSED

  1. continued from Case 1
  2. clicked OK on the infobar
  3. confirmed infobar dismissed
  4. opened brave://settings/?search=web+discovery and confirmed Web Discovery Project is enabled
steps 1-2 step 3 step 4
Screen Shot 2022-12-12 at 12 34 57 PM Screen Shot 2022-12-12 at 12 39 48 PM Screen Shot 2022-12-12 at 12 39 42 PM

Case 3: Dismiss (x) the infobar - PASSED

  1. new profile
  2. opened brave://settings/search
  3. set Google as the search-engine entry for Normal Window
  4. set Brave as the search-engine entry for Normal Window
  5. visited https://search.brave.com
  6. confirmed WDP infobar was shown with text Help improve Brave Search by sending anonymous usage data
  7. click x to dismiss the infobar
  8. confirmed WDP infobar was hidden
steps 2-3 step 4 step 6 step 8
Screen Shot 2022-12-12 at 12 47 20 PM Screen Shot 2022-12-12 at 12 47 47 PM Screen Shot 2022-12-12 at 12 49 07 PM Screen Shot 2022-12-12 at 12 49 18 PM

Case 4: Show infobar again, after dismissal - PASSED

Pre-req: Dismiss (x) the infobar from Case 3

  1. closed Brave
  2. opened Preferences from my main profile folder, in Atom
  3. tweaked the value of web_discovery.last_displayed to make it lower (longer ago, to simulate a 24 hours passing)
  4. relaunched Brave
  5. confirmed I got the WDP infobar again
pre-req step 3 step 4 result
Screen Shot 2022-12-12 at 12 49 18 PM Screen Shot 2022-12-12 at 1 01 07 PM Screen Shot 2022-12-12 at 1 06 51 PM Screen Shot 2022-12-12 at 12 49 07 PM

Case 5: Dismiss the infobar (No thanks) - PASSED

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. set Google as the default search engine for Normal Window
  5. set Brave as the default search engine for Normal Window
  6. visited https://search.brave.com
  7. clicked No thanks on the infobar
  8. closed and relaunched Brave
  9. reloaded https://search.brave.com
  10. confirmed the WDP infobar isn't shown
step 7 step 10
Screen Shot 2022-12-12 at 2 03 59 PM Screen Shot 2022-12-12 at 2 04 20 PM

Case 6: Infobar is shown once per day if not dismissed - PASSED

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. set Google as the default search engine for the Normal Window entry
  5. set Brave as the default search engine for the Normal Window entry
  6. loaded https://search.brave.com/search?q=Brave&source=web
  7. confirmed the WDP infobar displayed
  8. did NOT click (x) to dismiss the infobar
  9. closed Brave
  10. advanced system clock to tomorrow, Dec 13, 2022
  11. relaunched Brave
  12. confirmed I saw the WDP infobar
step 7 step 10 step 12
Screen Shot 2022-12-12 at 2 08 55 PM Screen Shot 2022-12-12 at 2 12 13 PM Screen Shot 2022-12-13 at 2 12 22 PM

Case 7: Edit CTA id in the Preferences file once infobar is dismissed - PASSED

  1. continued from Case 5
  2. closed Brave
  3. opened Preferences in Atom
  4. changed v1 to g1
  5. relaunched Brave
  6. reloaded search.brave.com
  7. confirmed infobar was shown
step 4 step 5 step 7
Screen Shot 2022-12-13 at 2 19 54 PM Screen Shot 2022-12-13 at 2 20 24 PM Screen Shot 2022-12-13 at 2 20 19 PM

Case 8: Infobar is shown 5 times at most for a profile if not dismissed - PASSED

  1. new profile
  2. launched Brave
  3. opened brave://settings/search in a new tab
  4. set Google as the default search engine for Normal Window
  5. set Brave as the default search engine for Normal Window
  6. visited https://search.brave.com and was shown WDP infobar
  7. opened Preferences and navigated to confirm: "count": 1
  8. closed Brave
  9. advanced system clock by 1 day
  10. relaunched Brave and confirmed the infobar was shown on search.brave.com page
  11. confirmed "count": 2 (increased by 1)
  12. repeated steps 9-11 3x until "count": 5
  13. repeated steps 9-11 for Day 6 / Run 6
  14. relaunched Brave
  15. confirmed the infobar is not shown on search.brave.com
step 4 step 5 step 6 step 7
Screen Shot 2022-12-12 at 3 26 29 PM Screen Shot 2022-12-12 at 3 26 34 PM Screen Shot 2022-12-12 at 3 26 40 PM Screen Shot 2022-12-12 at 3 25 10 PM

Days / Counts

Tue, count: 2 Wed, count: 3 Thu, count: 4 Fri, count: 5 Sat, count: 5
Screen Shot 2022-12-13 at 3 00 34 PM Screen Shot 2022-12-14 at 3 01 38 PM Screen Shot 2022-12-15 at 3 02 30 PM Screen Shot 2022-12-16 at 3 03 26 PM Screen Shot 2022-12-17 at 3 07 14 PM
WDP infobar present, counts 1-5 WDP infobar absent, counts 6+
Screen Shot 2022-12-16 at 3 03 40 PM Screen Shot 2022-12-16 at 3 03 54 PM

Verification passed on

Brave 1.47.125 Chromium: 108.0.5359.99 (Official Build) beta (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Ubuntu 18.04 LTS

Case 1: WDP infobar UI - PASSED

  1. opened brave://settings/search
  2. selected Google as the non-Brave Search default engine or Normal Window entry
  3. visited https://search.brave.com/?q=Brave&source=web
  4. confirmed WDP infobar wasn't shown
  5. enabled Web Discovery Project via brave://settings/?search=web+discovery
  6. set Brave as the default search engine for Normal Window
  7. reloaded https://search.brave.com/?q=Brave&source=web
  8. confirmed WDP infobar wasn't shown
  9. disabled WDP via brave://settings/?search=web+discovery
  10. reloaded https://search.brave.com/?q=Brave&source=web
  11. confirmed WDP infobar is shown with text Help improve Brave Search by sending anonymous usage data

image
image
image
image
image
image

Case 2: Opt-in to WDP - PASSED

  1. continued from Case 1
  2. clicked OK on the infobar
  3. confirmed infobar dismissed
  4. opened brave://settings/?search=web+discovery and confirmed Web Discovery Project is enabled

image

Case 3: Dismiss (x) the infobar - PASSED

  1. new profile
  2. opened brave://settings/search
  3. set Google as the search-engine entry for Normal Window
  4. set Brave as the search-engine entry for Normal Window
  5. visited https://search.brave.com
  6. confirmed WDP infobar was shown with text Help improve Brave Search by sending anonymous usage data
  7. click x to dismiss the infobar
  8. confirmed WDP infobar was hidden

image
image

Case 4: Show infobar again, after dismissal - PASSED

Pre-req: Dismiss (x) the infobar from Case 3

  1. closed Brave
  2. opened Preferences from my main profile folder, in Atom
  3. tweaked the value of web_discovery.last_displayed to make it lower (longer ago, to simulate a 24 hours passing)
  4. relaunched Brave
  5. confirmed I got the WDP infobar again

Case 5: Dismiss the infobar (No thanks) - PASSED

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. set Google as the default search engine for Normal Window
  5. set Brave as the default search engine for Normal Window
  6. visited https://search.brave.com
  7. clicked No thanks on the infobar
  8. closed and relaunched Brave
  9. reloaded https://search.brave.com
  10. confirmed the WDP infobar isn't shown

Case 6: Infobar is shown once per day if not dismissed - PASSED

  1. new profile
  2. launched Brave
  3. opened brave://settings/search
  4. set Google as the default search engine for the Normal Window entry
  5. set Brave as the default search engine for the Normal Window entry
  6. loaded https://search.brave.com/search?q=Brave&source=web
  7. confirmed the WDP infobar displayed
  8. did NOT click (x) to dismiss the infobar
  9. closed Brave
  10. advanced system clock to tomorrow, Dec 13, 2022
  11. relaunched Brave
  12. confirmed I saw the WDP infobar

Case 7: Edit CTA id in the Preferences file once infobar is dismissed - PASSED

  1. continued from Case 5
  2. closed Brave
  3. opened Preferences in Atom
  4. changed v1 to g1
  5. relaunched Brave
  6. reloaded search.brave.com
  7. confirmed infobar was shown

Case 8: Infobar is shown 5 times at most for a profile if not dismissed - PASSED

  1. new profile
  2. launched Brave
  3. opened brave://settings/search in a new tab
  4. set Google as the default search engine for Normal Window
  5. set Brave as the default search engine for Normal Window
  6. visited https://search.brave.com and was shown WDP infobar
  7. opened Preferences and navigated to confirm: "count": 1
  8. closed Brave
  9. advanced system clock by 1 day
  10. relaunched Brave and confirmed the infobar was shown on search.brave.com page
  11. confirmed "count": 2 (increased by 1)
  12. repeated steps 9-11 3x until "count": 5
  13. repeated steps 9-11 for Day 6 / Run 6
  14. relaunched Brave
  15. confirmed the infobar is not shown on search.brave.com

step 4 | step 5 | step 6 | step 7

Days / Counts

Tue, count: 2 | Wed, count: 3 | Thu, count: 4 | Fri, count: 5 | Sat, count: 5

WDP infobar present, counts 1-5 | WDP infobar absent, counts 6+

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 12, 2022
@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Use the infobar for WDP CTA instead of dialog brave/brave-core
7 participants
@stephendonner @rebron @simonhong @LaurenWags @btlechowski @brave-builds @MadhaviSeelam