Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Solana NFT support on Android #26617

Closed
SergeyZhukovsky opened this issue Nov 8, 2022 · 2 comments · Fixed by brave/brave-core#15849
Closed

Basic Solana NFT support on Android #26617

SergeyZhukovsky opened this issue Nov 8, 2022 · 2 comments · Fixed by brave/brave-core#15849
Assignees
@SergeyZhukovsky
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.45.x - Release #7

Comments

@SergeyZhukovsky
Copy link
Member

A full description is here #25864 (comment)
@SergeyZhukovsky SergeyZhukovsky added enhancement priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 8, 2022
@SergeyZhukovsky SergeyZhukovsky self-assigned this Nov 8, 2022
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Nov 8, 2022
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.47.x - Nightly milestone Nov 8, 2022
This was referenced Nov 8, 2022
Merged
Merged
@kjozwiak
Copy link
Member

The above will require 1.45.124 or higher for 1.45.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.45.125 x64 build

  • Verified steps from brave/brave-core#15849
  • Verified able to add Solana NFT via add custom token
  • Verified selecting NFT checkbox automatically hides the decimal value input and adds NFT
  • Verified NFT is listed in portofolio automatically
  • Verified correct NFT value is shown when account is switched
  • Send NFT will be checked as part of #26694
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
26617-ARM.mp4
26617-Tab.mp4

This was referenced Nov 15, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.45.x - Release #7
Development

Successfully merging a pull request may close this issue.

Adds a basic Solana NFT support on Android brave/brave-core
4 participants
@kjozwiak @SergeyZhukovsky @srirambv @brave-builds