Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Enable Show scrollable MVT on NTP feature by default #26942

Closed
samartnik opened this issue Nov 22, 2022 · 2 comments · Fixed by brave/brave-core#16084
Closed

[Android] Enable Show scrollable MVT on NTP feature by default #26942

samartnik opened this issue Nov 22, 2022 · 2 comments · Fixed by brave/brave-core#16084
Assignees

Comments

@samartnik
Copy link
Contributor

Description

This feature makes top sites section scrollable

screen-20221122-112319.mp4

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above will require 1.47.140 or higher for 1.47.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 9, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarmx64.apk_1.47.16

Clean profile

  • Ensured that the top sites in a NTP are scrollable
  • Ensured that user can tap on the top sites and open the sites
vidma_recorder_09012023_182243.mp4

Upgrade profile

  • Ensured that the top sites in a NTP are scrollable
  • Ensured that user can tap on the top sites and open the sites
vidma_recorder_09012023_182821.mp4

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants