[Android 13 ] show android 13 modal based update conidition

[sujitacharya2005]

Description

Show Rewards warning dialog , privacy warning dialog or combine message dialog.
Conditions

1. Notification permission is not there
2. Or particular notification group permission is off (Like Brave Ads or General Group is off)
3. Then check for rewards enabled or privacy feature enabled
4. show only one time this dialog for onBoarding
5. show one time for setting page

Steps to reproduce

This dialog is showing two place.

1. onBoarding time
2. Setting page notification click and back
3. base on above condition.

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version?
• Can you reproduce this issue with the current Play Store Beta version?
• Can you reproduce this issue with the current Play Store Nightly version?

Device details

• Install type (ARM, x86):
• Device type (Phone, Tablet, Phablet):
• Android version:

Brave version

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[kjozwiak]

The above requires 1.47.168 or higher for 1.47.x verification. @Uni-verse leave this one for me 👍

[kjozwiak]

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.47.171 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B1.221118.00

Test Case #1 (Generic Modal/Warning) - Both Rewards & Privacy Report disabled

• launch 1.47.171 Chromium: 109.0.5414.87 and run through onboarding
• tap on Continue via the Brave notifications make it easier modal
  • also ran through this case by tapping on Not now and ensuring notifications weren't being enabled with this method
• tap on Dont Allow via the Allow Brave to send you notifications modal
• go into Settings -> Notifications and notice that Notifications are disabled as expected
• tap on <- (back) to go back into Settings and ensure that you receive a generic warning re: notifications being disabled
• ensured that taping on Not now dismisses the modal without any issues
• ensured that tapping on Continue takes you back into the Notifications screen without an issues
  • ensured that going back into Settings didn't display the generic warning modal re: notifications being disabled
• ensured that once either Not now or Continue has been tapped, the generic warning modal doesn't appear again
  • also ensured that the generic modal doesn't re-appear if the browser was closed while the modal was still opened

Example	Example	Example	Example	Example

Test Case #2 (Generic Modal/Warning) - Rewards enabled & Privacy Report disabled

• launch 1.47.171 Chromium: 109.0.5414.87 and run through onboarding
• tap on Continue via the Brave notifications make it easier modal
• tap on Allow via the Allow Brave to send you notifications modal to enable notifications
• enable rewards via the rewards panel (run through country selection/onboarding)
• once rewards has been enabled, go into Settings -> Notifications
• toggle/disable All Brave - notifications from the Notifications page
• tap on <- (back) to return into Settings and ensure that you don't get any warning modals
• close the Settings page
• go back into Settings -> Notifications
• tap on <- (back) and ensure that you receive a generic warning re: notifications being disabled
• ensured that taping on Not now dismisses the modal without any issues
• ensured that tapping on Continue takes you back into the Notifications screen without an issues
  • ensured that going back into Settings didn't display the generic warning modal re: notifications being disabled
• ensured that once either Not now or Continue has been tapped, the generic warning modal doesn't appear again
  • also ensured that the generic modal doesn't re-appear if the browser was closed while the modal was still opened

Example	Example	Example	Example	Example	Example

Test Case #3 (Generic Modal/Warning) - Rewards disabled & Privacy Report enabled

• launch 1.47.171 Chromium: 109.0.5414.87 and run through onboarding
• tap on Continue via the Brave notifications make it easier modal
• tap on Allow via the Allow Brave to send you notifications modal to enable notifications
• tap on the Brave Stats via NTP and run through the Privacy Report onboarding (ensure you enable Privacy Report)
• visit Settings -> Notifications and toggle/disable All Brave - notifications from the Notifications page
• tap on <- (back) to return into Settings and ensure that you don't get any warning modals
• close the Settings page
• go back into Settings -> Notifications
• tap on <- (back) and ensure that you receive a generic warning re: notifications being disabled
• ensured that taping on Not now dismisses the modal without any issues
• ensured that tapping on Continue takes you back into the Notifications screen without an issues
  • ensured that going back into Settings didn't display the generic warning modal re: notifications being disabled
• ensured that once either Not now or Continue has been tapped, the generic warning modal doesn't appear again
  • also ensured that the generic modal doesn't re-appear if the browser was closed while the modal was still opened
• ensured that there's a banner warning the user that Notifications are disabled within the Privacy Report
  • ensured that tapping on Turn on notifications redirects you to Settings -> Notifications
  • ensured that tapping on <- (back) within Notifications takes you back to the Privacy Report
  • ensured that warning re-appears if the user dismissed via X and then restarted the browser

Example	Example	Example	Example	Example	Example	Example	Example

Test Case #4 (Generic Modal/Warning) - Rewards enabled & Privacy Report enabled

With the following case, basically follow Test Case #2 & Test Case #3 in terms of enabling both features and then disabling All Brave - notifications and ensuring you get a the generic warning modal as per the following:

Example	Example	Example	Example	Example	Example	Example

Test Case #5 (Reward/Warning) - Rewards enabled & Privacy Report disabled

• launch 1.47.171 Chromium: 109.0.5414.87 and run through onboarding
• tap on Continue via the Brave notifications make it easier modal
• tap on Allow via the Allow Brave to send you notifications modal to enable notifications
• enable rewards via the rewards panel (run through country selection/onboarding)
• once rewards has been enabled, go into Settings -> Notifications
• toggle/disable All "Brave Ads" notifications from the Notifications page
• tap on <- (back) to return into Settings and ensure that you get the You're not earning Brave Rewards warning modal
  • ensure that tapping on X or Got it dismiss the modal without any issues
  • ensured that the same modal never appears again when going back from Notifications -> Settings again
• close the Settings page and restart the browser
• ensure that you get the You're not earning Brave Rewards warning modal
• ensured that taping on Not now dismisses the modal without any issues
• ensured that tapping on Turn on Brave notifications takes you to the Settings -> Notifications page within Brave
• ensured that once either Not now or Turn on Brave notifications has been tapped, the warning modal never appears again
  • also ensured that the rewards warning modal doesn't re-appear if the browser was closed while the modal was still opened

Example	Example	Example	Example	Example	Example	Example	Example

Test Case #6 (Privacy Report/Warning) - Rewards disabled & Privacy Report enabled

• launch 1.47.171 Chromium: 109.0.5414.87 and run through onboarding
• tap on Continue via the Brave notifications make it easier modal
• tap on Allow via the Allow Brave to send you notifications modal to enable notifications
• enable Privacy Report by tapping on the Brave Stats and running through onboarding
• once Privacy Report has been enabled, go into Settings -> Notifications
• toggle/disable All "General" notifications from the Notifications page
• tap on <- (back) to return into Settings and ensure that you get the You're not receiving Privacy Reports warning modal
  • ensure that tapping on X or Got it dismiss the modal without any issues
  • ensured that the same modal never appears again when going back from Notifications -> Settings again
• close the Settings page and restart the browser
• ensure that you get the You're not receiving Privacy Reports warning modal
• ensured that taping on Not now dismisses the modal without any issues
• ensured that tapping on Turn on Brave notifications takes you to the Settings -> Notifications page within Brave
• ensured that once either Not now or Turn on Brave notifications has been tapped, the warning modal never appears again
  • also ensured that the privacy report warning modal doesn't re-appear if the browser was closed while the modal was still opened

Example	Example	Example	Example	Example	Example	Example

Test Case #7 (Reward & Privacy Report/Warning) - Rewards enabled & Privacy Report enabled

With the following case, basically follow Test Case #5 & Test Case #6 in terms of enabling both features and then disabling All "Brave Ads" notifications & All "General" notifications and ensuring you get the combined warning modal as per the following:

Example	Example	Example	Example	Example	Example