Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "add custom asset" dialog to full screen and create separate NFT screen to add NFT #27070

Closed
Pavneet-Sing opened this issue Nov 30, 2022 · 1 comment · Fixed by brave/brave-core#19195
Closed

Convert "add custom asset" dialog to full screen and create separate NFT screen to add NFT #27070

Pavneet-Sing opened this issue Nov 30, 2022 · 1 comment · Fixed by brave/brave-core#19195
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Nov 30, 2022 •
edited by simoarpe
Loading

Description

Convert "Add custom asset" and "Add NFT" dialogs into a full screen and show appropriate fields for adding NFTs or custom assets.

Current Android UI

Asset NFT
Screenshot 2023-06-30 at 11 09 27 AM Screenshot 2023-06-30 at 11 10 53 AM

iOS Preview

Asset NFT
drawing drawing
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Nov 30, 2022
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Jun 8, 2023
@simoarpe simoarpe self-assigned this Jun 28, 2023
This was referenced Jun 30, 2023
Closed
Merged
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 11, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified steps from brave/brave-core#19195
  • Verified able to add custom asset/NFT
  • Verified add custom token is shown in full screen similar to iOS
27070.mp4

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Convert "Add custom asset" dialog to full screen brave/brave-core
5 participants
@simoarpe @Pavneet-Sing @HEagle18 @srirambv @brave-builds