Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add help centre link to the wallet #27270

Closed
HEagle18 opened this issue Dec 9, 2022 · 4 comments · Fixed by brave/brave-core#19692
Closed

Add help centre link to the wallet #27270

HEagle18 opened this issue Dec 9, 2022 · 4 comments · Fixed by brave/brave-core#19692
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@HEagle18
Copy link

HEagle18 commented Dec 9, 2022 •
edited by Pavneet-Sing
Loading

Description

Right now we have a help centre link on desktop, I would like to see this on Android as well. Maybe we can insert it on this dropdown

Screenshot 2022-12-09 at 14 48 21

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1675951645322039
@HEagle18 HEagle18 added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 9, 2022
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Dec 9, 2022
@HEagle18
Copy link
Author

cc @kleantzogu

@HEagle18 HEagle18 added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Feb 9, 2023
@HEagle18
Copy link
Author

HEagle18 commented Feb 9, 2023

Screenshot 2023-02-09 at 15 15 24

Screenshot 2023-02-09 at 15 15 32

What it looks like on desktop

@Pavneet-Sing Pavneet-Sing self-assigned this Feb 9, 2023
@kleantzogu
Copy link

Figma link: https://www.figma.com/file/ZK2POu5oNDFtOoz3Xpr9mi/%F0%9F%93%B1-Help-Center?node-id=1701%3A25802&t=r7T7XPSQ5I0j3TVx-4

@srirambv srirambv mentioned this issue May 9, 2023
Closed
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 15, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 16, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.58.93 x64 Beta build

  • Verified steps from brave/brave-core#19692
  • Verified Help Centre link is available in Wallet setting and Panel settings
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27270-ARM.mp4
27270-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Show help centre brave/brave-core
6 participants
@jamesmudgett @kleantzogu @Pavneet-Sing @HEagle18 @srirambv @brave-builds