Crash on permissions

[SergeyZhukovsky]

That crash was found on a beta channel in GPS on 1.48.x. It fails in that place https://github.com/brave/brave-core/blob/1.48.x/android/java/org/chromium/chrome/browser/notifications/BravePermissionUtils.java#L65

Stack trace:

Exception java.lang.RuntimeException:
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:5312)
  at android.app.ActivityThread.handleResumeActivity (ActivityThread.java:5351)
  at android.app.servertransaction.ResumeActivityItem.execute (ResumeActivityItem.java:54)
  at android.app.servertransaction.ActivityTransactionItem.execute (ActivityTransactionItem.java:45)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:176)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2443)
  at android.os.Handler.dispatchMessage (Handler.java:106)
  at android.os.Looper.loopOnce (Looper.java:226)
  at android.os.Looper.loop (Looper.java:313)
  at android.app.ActivityThread.main (ActivityThread.java:8751)
  at java.lang.reflect.Method.invoke (Method.java)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:571)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1135)
Caused by java.lang.NullPointerException:
  at org.chromium.chrome.browser.notifications.BravePermissionUtils$$InternalSyntheticApiModelOutline$1$97647a16c2480f825cde2f80caf8099a7aa3d4d58a19b9135fc14c5c280b4be9$1.m (BravePermissionUtils.java:1)
  at org.chromium.chrome.browser.notifications.BravePermissionUtils.channeGroupIsBlocked (BravePermissionUtils.java:65)
  at org.chromium.chrome.browser.notifications.BravePermissionUtils.isBraveAdsNotificationPermissionBlocked (BravePermissionUtils.java:72)
  at org.chromium.chrome.browser.notifications.BraveNotificationWarningDialog.shouldShowRewardWarningDialog (BraveNotificationWarningDialog.java:94)
  at org.chromium.chrome.browser.notifications.BraveNotificationWarningDialog.shouldShowNotificationWarningDialog (BraveNotificationWarningDialog.java:86)
  at org.chromium.chrome.browser.app.BraveActivity.checkAndshowNotificationWarningDialog (BraveActivity.java:1334)
  at org.chromium.chrome.browser.app.BraveActivity.onNewIntent (BraveActivity.java:1716)
  at org.chromium.chrome.browser.ChromeTabbedActivity.onNewIntent (ChromeTabbedActivity.java:971)
  at android.app.Activity.performNewIntent (Activity.java:8306)
  at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1429)
  at android.app.Instrumentation.callActivityOnNewIntent (Instrumentation.java:1442)
  at android.app.ActivityThread.deliverNewIntents (ActivityThread.java:4317)
  at android.app.ActivityThread.performResumeActivity (ActivityThread.java:5275)

[kjozwiak]

That crash was found on a beta channel in GPS on 1.48.x.

@SergeyZhukovsky did you mean to mention 1.47.x instead of 1.48.x?

[SergeyZhukovsky]

@kjozwiak it happens in 1.47.x as well, the stack is just from 1.48.x

[kjozwiak]

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.47.175 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 12; Build/SP1A.210812.016

Went through the STR/Cases outlined via brave/brave-core#16128 (comment) & brave/brave-core#16651 (comment) and ensured everything was working as expected without any issues.

---

Verification PASSED on Pixel 6+ running Android 13 using the following build(s):

Brave | 1.47.175 Chromium: 109.0.5414.87 (Official Build) (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B2.221216.006

Went through the STR/Cases outlined via brave/brave-core#16128 (comment) & brave/brave-core#16651 (comment) and ensured everything was working as expected without any issues.