Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some $removeparam filter rules are not being applied to document requests #27819

Closed
antonok-edm opened this issue Jan 14, 2023 · 5 comments · Fixed by brave/brave-core#16682
Closed

Comments

@antonok-edm
Copy link
Collaborator

Reports from the community:

This can be fixed by updating adblock-rust to v0.6.2 - see brave/adblock-rust@8a755bd

@kjozwiak
Copy link
Member

The above requires 1.47.176 or higher for 1.47.x verification 👍

@btlechowski
Copy link

Verification passed on

Brave 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Ubuntu 18.04 LTS

Reproduced the issue in 1.47.169 using test plan from brave/brave-core#16682

Applied rules
image
parameter irgwc is still visible in the URL
image

Verified in 1.47.177 using test plan from brave/brave-core#16682

Applied rules:
image

parameter irgwc is removed
image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 19, 2023

Verification PASSED using

Brave | 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
-- | --
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Reproduced in 1.47.171 using testplan from brave/brave-core#16682 (comment)

image

Steps:

  1. Install 1.47.177
  2. launch Brave
  3. open a new-tab
  4. go to brave://settings/shields/filters
  5. paste https://filters.adtidy.org/windows/filters/17.txt in the Add custom filter lists textbox
  6. click Add
  7. open a new-tab
  8. visit https://www.agoda.com/?site_id=1887945&irgwc=1

Confirmed irgwc=1 is not shown in the URL

step 5-6 step 8
image image

@stephendonner
Copy link

Verification PASSED using

Brave 1.47.177 Chromium: 109.0.5414.87 (Official Build) (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Reproduced in 1.47.171 using testplan from brave/brave-core#16682 (comment)

Screen Shot 2023-01-19 at 10 07 46 AM

Steps:

  1. installed 1.47.177
  2. launched Brave
  3. opened a new-tab page
  4. opened brave://settings/shields/filters
  5. pasted https://filters.adtidy.org/windows/filters/17.txt in the Add custom filter lists textbox
  6. clicked Add
  7. opened a new-tab page
  8. loaded https://www.agoda.com/?site_id=1887945&irgwc=1

Confirmed irgwc=1 is not shown in the URL

steps 5-6 step 8
Screen Shot 2023-01-19 at 10 10 51 AM Screen Shot 2023-01-19 at 10 10 40 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following version(s):

Brave	1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 13; Build/TP1A.220624.014
Brave	1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit) 
Revision	2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS	Android 12; Build/SP2A.220305.013

STR: brave/brave-core#16682 (comment)

Verified irgwc=1 does not appear in the URL after loading https://www.agoda.com/?site_id=1887945&irgwc=1

Custom Filters Test URL
screenshot-1674501586938 screenshot-1674501727184
screenshot-1674502079601 screenshot-1674502123240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment