-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Implement vBAT notices and sunset #27883
Comments
We'll try getting this verified/checked on an older device like |
Verification PASSED on Verified the scenarios from https://docs.google.com/document/d/1YVa6Wx4kMd90Q7mfx29iW--xa4tPNl7YXc486CkYQAI/edit#heading=h.t2vdk6dnw3tr Note: Reset rewards cases are NOT verified, thread about the discussion https://bravesoftware.slack.com/archives/CNH9Q6REV/p1675080664239119?thread_ts=1675061489.249839&cid=CNH9Q6REV Case 1: vbatDeadline not specified_PASSED1.1. In older version of Brave, create a Rewards profile in staging (ideally select a country with a supported custodian and that you have a matching account for, such as UK) 1.2. Upgrade the profile to 1.49.x
Logs:
1.5. Connect to a custodian. You are now in the connected state.
1.6. Make sure /parameters endpoint is still not showing any vbatDeadline value
1.9. Reset Brave Rewards. You should now be in the new non-connected state.
1.14. Make sure /parameters endpoint is still not showing any vbatDeadline value. Logs:
1.15. You should be in the new non-connected state.
Case 2: vbatDeadline is in the past_FAILED_Logged #288172.1. In older version of Brave, create a Rewards profile in staging (ideally select a country with a supported custodian and that you have a matching account for, such as UK) 2.3. Upgrade the profile to 1.49.x Logs
2.6. Look at NTP Rewards Widget, Rewards panel, and brave://rewards page. Make sure there are no vBAT expiry notices anywhere. Encountered the issue #28817
2.7. Connect to a custodian. You are now in the connected state.
2.9. Restart browser just in case.
2.11. Reset Brave Rewards. You should now be in the new non-connected state. (NA)
Case 3: vbatDeadline is in the future (custodian available → connected → reset into non-connected)_FAILED_Logged #288163.1. In older version of Brave, create a Rewards profile in staging (ideally select a country with a supported custodian and that you have a matching account for, such as UK) 3.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is in the future. Note that vbatDeadline is a UTC date.
3.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices. They SHOULD appear
3.6. Inside each of the notices, make sure the date and time correspond with what’s at the /parameters endpoint. The parameters endpoint is in UTC, and the value shown in notices should be translated into your local device time.
3.7. In the NTP Rewards widget, close the vBAT expiry notice. Then, refresh the NTP and it should appear again. (NA)
3.9. Connect a custodian.
3.11. Reset Brave Rewards and enable Brave Rewards. You’re now in the non-connected state. Check NTP, brave://rewards and Rewards dropdown panel. NO vBAT expiry notices should appear anywhere. (NA see comments) Case 4: Japan version of vbatDeadline is in the future (custodian available → connected → reset into non-connected)_PASSED4.1. In older version of Brave, create a Rewards profile in staging and declare JP region 4.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is in the future. Note that vbatDeadline is a UTC date.
4.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices. They SHOULD appear
4.6. Inside each of the notices, make sure the date and time correspond with what’s at the /parameters endpoint. The parameters endpoint is in UTC, and the value shown in notices should be translated into your local device time.
4.7. In the NTP Rewards widget, close the vBAT expiry notice. Then, refresh the NTP and it should appear again. (NA) 4.8. In the Rewards dropdown panel, close the vBAT expiry notice. Then, close and open the dropdown panel again. It should reappear again.
4.9. Connect a custodian.
4.11. Reset Brave Rewards and enable Brave Rewards. You’re now in the non-connected state. Check NTP, brave://rewards and Rewards dropdown panel. NO vBAT expiry notices should appear anywhere. (NA) Case 5: vbatDeadline is in the future (custodian available → not available → available → connected → reset into non-connected)_PASSED5.1. Create a profile on 1.47.x or earlier and enable Rewards against staging in the US. 5.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is in the future. Note that vbatDeadline is a UTC date.
5.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices.
5.6. Inside each of the notices, make sure the date and time correspond with what’s at the /parameters endpoint. The parameters endpoint is in UTC, and the value shown in notices should be translated into your local device time. 5.7. Now, have Ben Huson or proxy the /parameters endpoint so that there are NO available custodians for your region (in this example, US). I have added "GB" in the region not supported block for Uphold custodian 5.8. Make sure these new values are being picked up by the browser (e.g., try a browser restart). Logs:
5.9. Check for vBAT notices on NTP, brave://rewards, and Rewards dropdown. However, they should now be the variant that says “no available custodian” (matches Figma row “Countdown to feature removal notification + No custodians available”). Make sure the “Learn more” buttons work in all of them (open up relevant pages).
5.10. In the NTP Rewards widget, close the vBAT expiry notice. Then, refresh the NTP and it should appear again (NA) 5.11. In the Rewards dropdown panel, close the vBAT expiry notice. Then, close and open the dropdown panel again. It should reappear again.
5.12. Now, update /parameters endpoint so that there is at least 1 available custodian for GB, then confirm new /parameters values are being picked up by the browser.
5.13. Check to see if vBAT notices have returned to looking like Figma’s row “Countdown to feature removal notification”, which allows a user to connect custodian. Make sure the “Connect account” and “Learn more” buttons work in all of them (open up relevant pages or modals, but do not connect to custodian yet).
5.14. Connect a custodian.
5.16. Reset Brave Rewards then re-enable Rewards. You should now be in the non-connected state. Case 6: Custodian available → forcible transition to non-connected_PASSED6.1 Create a profile on 1.47.x or earlier and enable Rewards against staging in the UK. 6.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is sometime in the future.
6.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices (available custodian case).
6.6. Now, change /parameters to vbatDeadline to sometime in the recent past, and vbatExpired: true.
6.8. Check Brave Rewards UI: user should now see the new non-connected state and no longer see the grandfathered-unverified state. No vBAT notices should appear anywhere. Do a general scan to make sure NTP widget, brave://rewards and Rewards dropdown panel match the new non-connected state.
Case 7: Japan version of custodian available → forcible transition to non-connected_PASSED7.1 Create a profile on 1.47.x or earlier and enable Rewards against staging and select the JP region 7.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is sometime in the future.
7.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices (available custodian case).
7.6. Now, change /parameters to vbatDeadline to sometime in the recent past, and vbatExpired: true.
7.8. Check Brave Rewards UI: user should now see the new non-connected state and no longer see the grandfathered-unverified state. No vBAT notices should appear anywhere. Do a general scan to make sure NTP widget, brave://rewards and Rewards dropdown panel match the new non-connected state.
Case 8: No custodian available → forcible transition to non-connected_PASSED8.1. Create a profile on 1.47.x or earlier and enable Rewards against staging in a region that has no supported custodians (like Antarctica). 8.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is sometime in the future.
8.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices (no available custodian case).
8.6. Now, change /parameters to vbatDeadline to sometime in the recent past, and vbatExpired: true.
8.8. Check Brave Rewards UI: user should now see the new non-connected state and no longer see the grandfathered-unverified state. No vBAT notices should appear anywhere. Do a general scan to make sure NTP widget, brave://rewards and Rewards dropdown panel match the new non-connected state.
Case 9: vBAT flag (custodian available → flag → unflag → no custodian available → flag)_PASSED9.1. Create a profile on 1.47.x or earlier and enable Rewards against staging in the US. 9.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is sometime in the future.
Logs:
9.5. Go to brave://flags and set BraveRewardsVBatNotice feature flag to “disabled”. 9.7. Look around and make sure there are no vBAT expiry notices visible anymore.
9.8. Go to brave://flags and set BraveRewardsVBatNotice feature flag to “enabled”. Relaunch browser. 9.9. Make sure vBAT expiry notices appear again.
9.10. Change /parameters so that there are no available custodians for your region (in this example, UK)
9.11. vBAT notices should now show the Figma “Countdown to feature removal notification + No custodians available” case.
9.12. Go to brave://flags and set BraveRewardsVBatNotice feature flag to “disabled”. Relaunch browser. 9.13. Make sure all vBAT notices have disappeared.
9.14. Go to brave://flags and set BraveRewardsVBatNotice feature flag to “enabled”. Relaunch browser. 9.15. Make sure all vBAT notices have reappeared.
9.16. Reset Brave Rewards so that you’re in the non-connected state. (NA) |
Verification PASSED on Verified the scenarios from https://docs.google.com/document/d/1YVa6Wx4kMd90Q7mfx29iW--xa4tPNl7YXc486CkYQAI/edit#heading=h.t2vdk6dnw3tr Note: Reset rewards cases are NOT verified, thread about the discussion https://bravesoftware.slack.com/archives/CNH9Q6REV/p1675080664239119?thread_ts=1675061489.249839&cid=CNH9Q6REV Encountered #28817 Case 1: vbatDeadline not specified_PASSED1.1. In older version of Brave, create a Rewards profile in staging (ideally select a country with a supported custodian and that you have a matching account for, such as UK) 1.2. Upgrade the profile to 1.49.x
Logs:
1.5. Connect to a custodian. You are now in the connected state.
1.6. Make sure /parameters endpoint is still not showing any vbatDeadline value
1.9. Reset Brave Rewards. You should now be in the new non-connected state.
1.14. Make sure /parameters endpoint is still not showing any vbatDeadline value. Logs:
1.15. You should be in the new non-connected state.
Case 2: vbatDeadline is in the past_FAILED_encountered #288172.1. In older version of Brave, create a Rewards profile in staging (ideally select a country with a supported custodian and that you have a matching account for, such as UK) 2.3. Upgrade the profile to 1.49.x Logs
2.6. Look at NTP Rewards Widget, Rewards panel, and brave://rewards page. Make sure there are no vBAT expiry notices anywhere. Encountered the issue #28817
2.7. Connect to a custodian. You are now in the connected state.
2.9. Restart browser just in case.
2.11. Reset Brave Rewards. You should now be in the new non-connected state. (NA)
Case 3: vbatDeadline is in the future (custodian available → connected → reset into non-connected)_FAILED_encountered #288163.1. In older version of Brave, create a Rewards profile in staging (ideally select a country with a supported custodian and that you have a matching account for, such as UK) 3.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is in the future. Note that vbatDeadline is a UTC date.
3.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices. They SHOULD appear
3.6. Inside each of the notices, make sure the date and time correspond with what’s at the /parameters endpoint. The parameters endpoint is in UTC, and the value shown in notices should be translated into your local device time.
3.7. In the NTP Rewards widget, close the vBAT expiry notice. Then, refresh the NTP and it should appear again. (NA)
3.9. Connect a custodian.
3.11. Reset Brave Rewards and enable Brave Rewards. You’re now in the non-connected state. Check NTP, brave://rewards and Rewards dropdown panel. NO vBAT expiry notices should appear anywhere. (NA see comments) Case 4: Japan version of vbatDeadline is in the future (custodian available → connected → reset into non-connected)_PASSED4.1. In older version of Brave, create a Rewards profile in staging and declare JP region 4.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is in the future. Note that vbatDeadline is a UTC date.
4.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices. They SHOULD appear
4.6. Inside each of the notices, make sure the date and time correspond with what’s at the /parameters endpoint. The parameters endpoint is in UTC, and the value shown in notices should be translated into your local device time.
4.7. In the NTP Rewards widget, close the vBAT expiry notice. Then, refresh the NTP and it should appear again. (NA) 4.8. In the Rewards dropdown panel, close the vBAT expiry notice. Then, close and open the dropdown panel again. It should reappear again.
4.9. Connect a custodian.
4.11. Reset Brave Rewards and enable Brave Rewards. You’re now in the non-connected state. Check NTP, brave://rewards and Rewards dropdown panel. NO vBAT expiry notices should appear anywhere. (NA) Case 7: Japan version of custodian available → forcible transition to non-connected_PASSED7.1 Create a profile on 1.47.x or earlier and enable Rewards against staging and select the JP region 1.47.x rewards settings 7.2. Update parameters endpoint (or set up a proxy) so that vbatDeadline is sometime in the future.
7.5. Go to NTP Rewards widget, brave://rewards, and Rewards dropdown panel and check for notices (available custodian case).
7.6. Now, change /parameters to vbatDeadline to sometime in the recent past, and vbatExpired: true.
7.8. Check Brave Rewards UI: user should now see the new non-connected state and no longer see the grandfathered-unverified state. No vBAT notices should appear anywhere. Do a general scan to make sure NTP widget, brave://rewards and Rewards dropdown panel match the new non-connected state.
|
Description
Implement vBAT notices and sunsetting related to https://brave.com/rewards-changes.
The text was updated successfully, but these errors were encountered: