Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields notification number behavior needs updated #2793

Closed
rossmoody opened this issue Jan 2, 2019 · 1 comment
Closed

Shields notification number behavior needs updated #2793

rossmoody opened this issue Jan 2, 2019 · 1 comment
Labels
closed/invalid feature/shields The overall Shields feature in Brave.

Comments

@rossmoody
Copy link
Contributor

The Shields icon number tally in the toolbar needs a behavior updates to be visible 100% of the time in both Off and On states. The current behavior is for the number to disappear entirely when shields is Off or not blocking anything. This behavior should be updated so when no ads are being blocked we will show a 0 indicating that no ads are currently being blocked. This goes for both off and on states.

image

@rossmoody rossmoody added the feature/shields The overall Shields feature in Brave. label Jan 2, 2019
@rebron rebron added this to the 1.x Backlog milestone Jan 4, 2019
@rossmoody
Copy link
Contributor Author

Getting ducks in a row, reviewing as a larger team and will circle back with more concise direction on Brave Action item behavior/styling.

@srirambv srirambv modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 29, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid feature/shields The overall Shields feature in Brave.
Projects
None yet
Development

No branches or pull requests

5 participants